{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":19816070,"defaultBranch":"11.5","name":"server","ownerLogin":"MariaDB","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2014-05-15T10:58:50.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/4739304?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1715217408.0","currentOid":""},"activityList":{"items":[{"before":null,"after":"dfcb8b380a186cd47efec1d31b1db7c8e4fe2943","ref":"refs/heads/bb-10.11-mdev-34064-ycp-demo","pushedAt":"2024-05-09T01:16:48.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"mariadb-YuchenPei","name":"Yuchen Pei","path":"/mariadb-YuchenPei","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/119280372?s=80&v=4"},"commit":{"message":"MDEV-34064 [demo] return error from ha_commit_trans() in rpl_slave_state::truncate_state_table(THD *thd)\n\njust a demo - a similar fix to MDEV-28105 and MDEV-27186.\n\nWhether the 12607 error makes sense is perhaps a different matter:\n\nmysqltest: At line 7: query 'CHANGE MASTER TO master_host='a',master_port=1,master_user='a',master_demote_to_slave=1' failed: <Unknown> (12607): This xid is not exist","shortMessageHtmlLink":"MDEV-34064 [demo] return error from ha_commit_trans() in rpl_slave_st…"}},{"before":"0bf7158551f82d8601a28b2f0faa424959d5deb1","after":"42865a199f06d4a510ad3007ac37bf8e57630da9","ref":"refs/heads/bb-10.5-mdev-29027","pushedAt":"2024-05-09T01:08:31.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"mariadb-YuchenPei","name":"Yuchen Pei","path":"/mariadb-YuchenPei","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/119280372?s=80&v=4"},"commit":{"message":"MDEV-29027 ASAN errors in spider_db_free_result after partition DDL\n\nSpider calls ha_spider::close() at least twice on ALTER TABLE ... ADD\nPARTITION. The first call frees wide_handler and the second call\naccesses wide_handler->trx->thd (heap-use-after-free).\n\nIn general, there seems to be no problem with using THD obtained by\nthe macro current_thd() except in background threads. Thus, we simply\nreplace wide_handler->trx->thd with current_thd().\n\nOriginal author: Nayuta Yanagasawa","shortMessageHtmlLink":"MDEV-29027 ASAN errors in spider_db_free_result after partition DDL"}},{"before":null,"after":"2c6a95b0cf0f1d36bc741f9919833365cf9ff064","ref":"refs/heads/bb-11.4-mdev-27186","pushedAt":"2024-05-09T01:02:48.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"mariadb-YuchenPei","name":"Yuchen Pei","path":"/mariadb-YuchenPei","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/119280372?s=80&v=4"},"commit":{"message":"MDEV-27186 spider/partition: Report error on info() failure\n\nLike MDEV-28105, spider may attempt to connect to remote server in\ninfo(), and it may emit an error upon failure to connect. In this\ncase, the downstream caller ha_partition::open() should return the\nerror to avoid inconsistency.\n\nThis fixes MDEV-27186, MDEV-27237, MDEV-27334, MDEV-28241, MDEV-34101.","shortMessageHtmlLink":"MDEV-27186 spider/partition: Report error on info() failure"}},{"before":"97ed2702354d03ebcb8795154a9b46918d43db43","after":"f90419360e0ecb5ee29a9a796382a2c2d6711cf0","ref":"refs/heads/bb-10.5-mdev-27186","pushedAt":"2024-05-09T00:57:47.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"mariadb-YuchenPei","name":"Yuchen Pei","path":"/mariadb-YuchenPei","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/119280372?s=80&v=4"},"commit":{"message":"MDEV-27186 spider/partition: Report error on info() failure\n\nLike MDEV-28105, spider may attempt to connect to remote server in\ninfo(), and it may emit an error upon failure to connect. In this\ncase, the downstream caller ha_partition::open() should return the\nerror to avoid inconsistency.\n\nThis fixes MDEV-27186, MDEV-27237, MDEV-27334, MDEV-28241, MDEV-34101.","shortMessageHtmlLink":"MDEV-27186 spider/partition: Report error on info() failure"}},{"before":"034ababa508615fc4ad1a047703ef21f6926d677","after":"867747204afd4a94885fdbdb2a1442ca35001f93","ref":"refs/heads/10.5","pushedAt":"2024-05-09T00:45:15.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"grooverdan","name":"Daniel Black","path":"/grooverdan","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/462287?s=80&v=4"},"commit":{"message":"MDEV-31566 Fix buffer overrun of column_json function\n\nThe accounting of the limit variable that represents the\namount of space left it the buffer was incorrect.\n\nAlso there was 1 or 2 bytes left to write that occured without\nthe buffer length being checked.\n\nReview: Sanja Byelkin","shortMessageHtmlLink":"MDEV-31566 Fix buffer overrun of column_json function"}},{"before":"77c0aa4162d7dfd4b9e8faa43044c6ea4bd63083","after":"97ed2702354d03ebcb8795154a9b46918d43db43","ref":"refs/heads/bb-10.5-mdev-27186","pushedAt":"2024-05-09T00:29:40.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"mariadb-YuchenPei","name":"Yuchen Pei","path":"/mariadb-YuchenPei","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/119280372?s=80&v=4"},"commit":{"message":"MDEV-27186 spider/partition: Report error on info() failure\n\nLike MDEV-28105, spider may attempt to connect to remote server in\ninfo(), and it may emit an error upon failure to connect. In this\ncase, the downstream caller ha_partition::open() should return the\nerror to avoid inconsistency.\n\nThis fixes MDEV-27186, MDEV-27237, MDEV-27334, MDEV-28241, MDEV-34101.","shortMessageHtmlLink":"MDEV-27186 spider/partition: Report error on info() failure"}},{"before":"77c0aa4162d7dfd4b9e8faa43044c6ea4bd63083","after":null,"ref":"refs/heads/bb-10.5-mdev-34101","pushedAt":"2024-05-09T00:29:25.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"mariadb-YuchenPei","name":"Yuchen Pei","path":"/mariadb-YuchenPei","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/119280372?s=80&v=4"}},{"before":null,"after":"77c0aa4162d7dfd4b9e8faa43044c6ea4bd63083","ref":"refs/heads/bb-10.5-mdev-27186","pushedAt":"2024-05-09T00:29:25.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"mariadb-YuchenPei","name":"Yuchen Pei","path":"/mariadb-YuchenPei","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/119280372?s=80&v=4"},"commit":{"message":"MDEV-34101 [demo] spider/partition: Report error on info() failure\n\nLike MDEV-28105, spider may attempt to connect to remote server in\ninfo(), and it may emit an error upon failure to connect. In this\ncase, the downstream caller ha_partition::open() should return the\nerror to avoid inconsistency.","shortMessageHtmlLink":"MDEV-34101 [demo] spider/partition: Report error on info() failure"}},{"before":"bbdda6aab0c824721340213732eabb35c37710a4","after":"a312bb5dfba16f220a49284e7eb27b501873d54d","ref":"refs/heads/bb-11.5-MDEV-33677-galera","pushedAt":"2024-05-09T00:18:34.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"sysprg","name":null,"path":"/sysprg","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/10448138?s=80&v=4"},"commit":{"message":"MDEV-33677 : Port Performance Schema for Galera from ES\n\nAdded performance schema tables for Galera.\nThis is a port of the code from ES 10.6.\n\nRefs:\nMENT-346  commit 86c06851\nMENT-346  commit 10d0fcaf\nMENT-1333 commit 2005adc3\nMENT-347  commit aaca43b4\nMENT-1370 commit 1f460e6b","shortMessageHtmlLink":"MDEV-33677 : Port Performance Schema for Galera from ES"}},{"before":"7b53672c63b24572a07cb3ba32f9c9fb1b226cb6","after":"887bb3f73555ff8a50138a580ca8308b9b5c069c","ref":"refs/heads/bb-10.6-release","pushedAt":"2024-05-08T23:55:41.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"vuvova","name":"Sergei Golubchik","path":"/vuvova","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2737648?s=80&v=4"},"commit":{"message":"columnstore 6.4.8-2","shortMessageHtmlLink":"columnstore 6.4.8-2"}},{"before":"29c185bd771ac441121468b3850d6dc8d13b8a1f","after":"034ababa508615fc4ad1a047703ef21f6926d677","ref":"refs/heads/10.5","pushedAt":"2024-05-08T23:53:44.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"grooverdan","name":"Daniel Black","path":"/grooverdan","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/462287?s=80&v=4"},"commit":{"message":"MDEV-34053 mariadbbackup privilege REPLICA MONITOR issue\n\nMariaDB-backup needs to check for SLAVE MONITOR as that is\nwhat is returned by SHOW GRANTS.\n\nUpdate test to ensure that warnings about missing privileges\ndo not occur when the backup is successful.\n\nReviewer: Andrew Hutchings\nThanks Eugene for reporting the issue.","shortMessageHtmlLink":"MDEV-34053 mariadbbackup privilege REPLICA MONITOR issue"}},{"before":"e93ef724eeccb04d48ed8181a5fee5eeb94039b4","after":"ebf2168a6d7206c16524ecf1dc7e48c1d4476b29","ref":"refs/heads/bb-10.5-mdev-30073-7","pushedAt":"2024-05-08T22:33:30.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"igorbabaev","name":"Igor Babaev","path":"/igorbabaev","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/7783432?s=80&v=4"},"commit":{"message":"MDEV-30073 Wrong result on 2nd execution of PS for query with NOT EXISTS\n\nThis is a preliminary patch to check possible failures in buildbot.\nVariant 7","shortMessageHtmlLink":"MDEV-30073 Wrong result on 2nd execution of PS for query with NOT EXISTS"}},{"before":"6f003b5d0797b77822c4fac57f353a046faf2760","after":"4aaa61d6bd5f5340276b038e90ba2f0bfcbb6e56","ref":"refs/heads/bb-10.5-MDEV-19520","pushedAt":"2024-05-08T20:49:39.000Z","pushType":"push","commitsCount":5,"pusher":{"login":"mariadb-RexJohnston","name":"Rex Johnston","path":"/mariadb-RexJohnston","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/117681572?s=80&v=4"},"commit":{"message":"MDEV-19520 pushdown_from_having_into_where() not calling fix_fields() correctly\n\nfix_fields() called in pushdown_from_having_into_where() assuming that the\nitem is immutable.\nnormalize_cond() extended to include (not f)=>(f == 0) to avoid the\nissue where NOT(field) was being transformed to (field == 0) during\nthis fix_fields call.","shortMessageHtmlLink":"MDEV-19520 pushdown_from_having_into_where() not calling fix_fields()…"}},{"before":null,"after":"6f003b5d0797b77822c4fac57f353a046faf2760","ref":"refs/heads/bb-10.5-MDEV-19520","pushedAt":"2024-05-08T20:19:05.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"mariadb-RexJohnston","name":"Rex Johnston","path":"/mariadb-RexJohnston","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/117681572?s=80&v=4"},"commit":{"message":"MDEV-29955 post-fix - add CMake policy CMP0074, so ZLIB_ROOT is not ignored","shortMessageHtmlLink":"MDEV-29955 post-fix - add CMake policy CMP0074, so ZLIB_ROOT is not i…"}},{"before":"42227a7bf0695778a12db5b6ed13ddc780e4c7d0","after":"1f7bdf2fe8c310a71218dea83b1b3e3a98477058","ref":"refs/heads/bb-11.4-vec-vicentiu-hugo","pushedAt":"2024-05-08T19:02:03.000Z","pushType":"push","commitsCount":4,"pusher":{"login":"cvicentiu","name":"Vicențiu-Marian Ciorbaru","path":"/cvicentiu","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2320573?s=80&v=4"},"commit":{"message":"Select neighbours improvements","shortMessageHtmlLink":"Select neighbours improvements"}},{"before":"6f003b5d0797b77822c4fac57f353a046faf2760","after":"29c185bd771ac441121468b3850d6dc8d13b8a1f","ref":"refs/heads/10.5","pushedAt":"2024-05-08T18:34:39.000Z","pushType":"push","commitsCount":4,"pusher":{"login":"vuvova","name":"Sergei Golubchik","path":"/vuvova","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2737648?s=80&v=4"},"commit":{"message":"test needs to cleanup after itself","shortMessageHtmlLink":"test needs to cleanup after itself"}},{"before":"8e76664a6cd3e04aa0469ad3fa39bf667ce492e8","after":"7b53672c63b24572a07cb3ba32f9c9fb1b226cb6","ref":"refs/heads/bb-10.6-release","pushedAt":"2024-05-08T18:07:21.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"vuvova","name":"Sergei Golubchik","path":"/vuvova","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2737648?s=80&v=4"},"commit":{"message":"Merge branch '10.5' into 10.6","shortMessageHtmlLink":"Merge branch '10.5' into 10.6"}},{"before":"9f4c731629e1f31c38c2590cff9d1d6523826096","after":"29c185bd771ac441121468b3850d6dc8d13b8a1f","ref":"refs/heads/bb-10.5-release","pushedAt":"2024-05-08T18:01:53.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"vuvova","name":"Sergei Golubchik","path":"/vuvova","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2737648?s=80&v=4"},"commit":{"message":"test needs to cleanup after itself","shortMessageHtmlLink":"test needs to cleanup after itself"}},{"before":"40b3525fcc79aef62ea1ae057ec5687a55c0630b","after":"6f003b5d0797b77822c4fac57f353a046faf2760","ref":"refs/heads/10.5","pushedAt":"2024-05-08T17:48:04.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"vaintroub","name":"Vladislav Vaintroub","path":"/vaintroub","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1708204?s=80&v=4"},"commit":{"message":"MDEV-29955 post-fix - add CMake policy CMP0074, so ZLIB_ROOT is not ignored","shortMessageHtmlLink":"MDEV-29955 post-fix - add CMake policy CMP0074, so ZLIB_ROOT is not i…"}},{"before":null,"after":"e4afa610539ae01164485554e2de839bea9de816","ref":"refs/heads/https/jira.mariadb.org/browse/MDEV-11588","pushedAt":"2024-05-08T17:40:30.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"mariadb-galinashalygina","name":null,"path":"/mariadb-galinashalygina","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/167353501?s=80&v=4"},"commit":{"message":"MDEV-7850: Extend GTID Binlog Events with Thread Id\n\nThis patch augments Gtid_log_event with the user thread-id.\nIn particular that compensates for the loss of this info in\nRows_log_events.\n\nGtid_log_event::thread_id gets visible in mysqlbinlog output like\n\n  #231025 16:21:45 server id 1  end_log_pos 537 CRC32 0x1cf1d963  GTID 0-1-2 ddl thread_id=10\n\nas a 32 bit unsigned integer. Note this is a 32-bit value, as\nthe connection id can only be 32 bits (see MDEV-15089 for\ndetails).\n\nWhile the size of Gtid event has grown by 4 bytes\nreplication from OLD <-> NEW is not affected by it. This patch\nalso slightly changes the logic to convert Gtid events to Query\nevents for older replicas which don't support Gtid. Instead of\nhard-coding the padding of the sys var section of the generated\nQuery event, the length to pad is dynamically calculated based\non the length of the Gtid event.\n\nThis work was started by the late Sujatha Sivakumar.\nBrandon Nesterenko took it over, reviewed initial patches and\nextended the work.\n\nAlso thanks to Andrei for his help in finalizing the fixes for\nMDEV-33924, which were squashed into this patch.\n\nReviewed-by:\n=============\nAndrei Elkin <andrei.elkin@mariadb.com>\nKristian Nielsen <knielsen@knielsen-hq.org>","shortMessageHtmlLink":"MDEV-7850: Extend GTID Binlog Events with Thread Id"}},{"before":"7bc03d6860baec2e3c4a424a0b9089334ca0461c","after":"8e76664a6cd3e04aa0469ad3fa39bf667ce492e8","ref":"refs/heads/bb-10.6-release","pushedAt":"2024-05-08T17:29:01.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"vuvova","name":"Sergei Golubchik","path":"/vuvova","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2737648?s=80&v=4"},"commit":{"message":"Merge branch '10.5' into 10.6","shortMessageHtmlLink":"Merge branch '10.5' into 10.6"}},{"before":"21abee60a27ba32ca90908947ec9cce8a00fbcdd","after":"9f4c731629e1f31c38c2590cff9d1d6523826096","ref":"refs/heads/bb-10.5-release","pushedAt":"2024-05-08T17:23:47.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"vuvova","name":"Sergei Golubchik","path":"/vuvova","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2737648?s=80&v=4"},"commit":{"message":"test needs to cleanup after itself","shortMessageHtmlLink":"test needs to cleanup after itself"}},{"before":"c1f3eff53f07654d84ff868f906ecda5d1fdf311","after":"a4c4bb339e70fc18babe58573c683d3d90677adb","ref":"refs/heads/bb-10.6-serg","pushedAt":"2024-05-08T17:18:30.000Z","pushType":"push","commitsCount":87,"pusher":{"login":"vuvova","name":"Sergei Golubchik","path":"/vuvova","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2737648?s=80&v=4"},"commit":{"message":"Merge branch 'bb-10.5-serg' into bb-10.6-serg","shortMessageHtmlLink":"Merge branch 'bb-10.5-serg' into bb-10.6-serg"}},{"before":"2a3a1baf64dcb9b95ea2fef1c6bd7be29f04436c","after":"a6c516ff587d7bd44b6c3fe97c4f35dabe849ef2","ref":"refs/heads/bb-11.1-MDEV-33533-v2","pushedAt":"2024-05-08T17:15:55.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"spetrunia","name":"Sergei Petrunia","path":"/spetrunia","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2734550?s=80&v=4"},"commit":{"message":"MDEV-33533: Crash at execution of DELETE when trying to use rowid filter\n\n(Based on original patch by Oleksandr Byelkin)\n\nMulti-table DELETE can execute via \"buffered\" mode: at phase #1 it collects\nrowids of rows to be deleted, then at phase #2 in multi_delete::do_deletes()\nit calls handler->rnd_pos() to read rows to be deleted and deletes them.\n\nThe problem occurred when phase #1 used Rowid Filter on the table that\nphase #2 would be deleting from.\nIn InnoDB, h->rnd_init(scan=false) and h->rnd_pos() is an index scan over PK\nunder the hood. So, at phase #2 ha_innobase::rnd_init() would try to use the\nRowid Filter and hit an assertion inside ha_innobase::rnd_init().\n\nNote that multi-table UPDATE works similarly but was not affected, because\npatch for MDEV-7487 added code to disable rowid filter for phase #2 in\nmulti_update::do_updates().\n\nThis patch changes the approach:\n- It makes InnoDB not use Rowid Filter in rnd_pos() scans: it is disabled in\n  ha_innobase::rnd_init() and enabled back in ha_innobase::rnd_end().\n- multi_update::do_updates() no longer disables Rowid Filter for phase#2 as\n  it is no longer necessary.","shortMessageHtmlLink":"MDEV-33533: Crash at execution of DELETE when trying to use rowid filter"}},{"before":"907435eda3a43abc0d32a5a0008632aabada9536","after":"6f003b5d0797b77822c4fac57f353a046faf2760","ref":"refs/heads/bb-10.5-wlad","pushedAt":"2024-05-08T16:31:58.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"vaintroub","name":"Vladislav Vaintroub","path":"/vaintroub","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1708204?s=80&v=4"},"commit":{"message":"MDEV-29955 post-fix - add CMake policy CMP0074, so ZLIB_ROOT is not ignored","shortMessageHtmlLink":"MDEV-29955 post-fix - add CMake policy CMP0074, so ZLIB_ROOT is not i…"}},{"before":"37d0801d510d90bc868e9d8c5f30c8e5be010aeb","after":"21abee60a27ba32ca90908947ec9cce8a00fbcdd","ref":"refs/heads/bb-10.5-release","pushedAt":"2024-05-08T16:31:55.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"vuvova","name":"Sergei Golubchik","path":"/vuvova","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2737648?s=80&v=4"},"commit":{"message":"don't wait indefinitely for signal handler in --bootstrap","shortMessageHtmlLink":"don't wait indefinitely for signal handler in --bootstrap"}},{"before":"992023bc025af1046cb2bd9af18042e498166691","after":"7bc03d6860baec2e3c4a424a0b9089334ca0461c","ref":"refs/heads/bb-10.6-release","pushedAt":"2024-05-08T15:20:58.000Z","pushType":"push","commitsCount":5,"pusher":{"login":"vuvova","name":"Sergei Golubchik","path":"/vuvova","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2737648?s=80&v=4"},"commit":{"message":"Merge branch 'bb-10.5-serg' into bb-10.6-serg","shortMessageHtmlLink":"Merge branch 'bb-10.5-serg' into bb-10.6-serg"}},{"before":"ec7e1104432f145bf48a47b5871ce7cd7deaa5dc","after":"37d0801d510d90bc868e9d8c5f30c8e5be010aeb","ref":"refs/heads/bb-10.5-release","pushedAt":"2024-05-08T13:43:28.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"vuvova","name":"Sergei Golubchik","path":"/vuvova","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2737648?s=80&v=4"},"commit":{"message":"Don't wait undefinitely for the signal thread to exit\n\nif it didn't die in 10 seconds, better to stop waiting, risking\na race condition if someone sends a SIGHUP at that very moment\n(the worst it can do is to crash on exit) than to wait forever","shortMessageHtmlLink":"Don't wait undefinitely for the signal thread to exit"}},{"before":"a4a4699cb1ca8748f1e545a46623733b9cc60e19","after":"777ba7f37749ae09c3014c31d5022e4f09da756f","ref":"refs/heads/bb-10.4-mdev-28509","pushedAt":"2024-05-08T13:33:23.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"DaveGosselin-MariaDB","name":"Dave Gosselin","path":"/DaveGosselin-MariaDB","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/113473632?s=80&v=4"},"commit":{"message":"MDEV-28509 Dereferenced null pointer of type 'struct JOIN_TAB' in add_key_field\n\nThis patch fixes a crash when calculating join statistics during query\noptimization for queries with dangling WINDOW references.  Put another way,\nthe system may crash when a query defines a WINDOW but doesn't then refer to\nit.\n\nItem::marker is overloaded for different uses, the most typical refer to it as\na bit field.  However, the setup_group function uses it to mark that a field\nwas found when traversing a GROUP BY.  Originally, this marking set the\nItem::marker field to 1 to indicate that it was found.  Later on in setup_group\n(and only when SQL mode ONLY_FULL_GROUP_BY is enabled), we would skip any such\nmarked fields when checking that fields only referenced those found in the\nGROUP BY; otherwise, it would be silly to find fields of the GROUP BY within\nthe GROUP BY field itself.  Setting Item::marker to 1 seemed mostly harmless\nat that point in time.  But later, in git sha 4d143a6ff6, we introduced\nseveral changes: (1) the value of marker in setup_group was changed from 1 to\nUNDEF_POS, (2) Item::marker was changed from uint8 to int8 (which has since\nbeen changed to an int), and (3) UNDEF_POS which is defined to be -1 was also\nadded.\n\nQueries that define WINDOWs internally will setup groups and orders as part\nof query processing via the setup_group function.  Consequently because of\nthe behavior described earlier above, such queries may have items with markers\nas UNDEF_POS (-1, or 0xffffffff) which is the same as marking all of the flag\nbits as set.  This is disastrous for those users of Item::marker which refer\nto it as a bit field as some of those bits are mutually exclusive in meaning,\nand in many places we don't mask the bits we're interested in, we just\ncompare the value of the field as a whole to some flag value with direct\ncomparison.  In particular, the method\nItem_direct_view_ref::grouping_field_transformer_for_where would\nincorrectly see that the ref's marker was set for substitution when it was\nactually -1, all bits set, taking the wrong execution path leading to the\ncrash.\n\nUpon return from the setup_group function, we set the value of the marker\nflag to zero if we set it to -1.  This preserves the marker behavior for\n'full group by' (if configured) while not otherwise allowing the marker\nflag state to leak outside of this function.","shortMessageHtmlLink":"MDEV-28509 Dereferenced null pointer of type 'struct JOIN_TAB' in add…"}},{"before":"288bed2c75ad6b15288fc3de44865191d794d2d7","after":"f6d5e26ae30d0fb51461449842153c2a57bbed81","ref":"refs/heads/bb-10.4-mdev-32424","pushedAt":"2024-05-08T13:32:54.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"DaveGosselin-MariaDB","name":"Dave Gosselin","path":"/DaveGosselin-MariaDB","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/113473632?s=80&v=4"},"commit":{"message":"MDEV-32424 Crash in subselect engine\n\nAccording to MDEV-29363, recompute the with_subquery() attribute\nin the pushdown code to avoid writing to freed memory.","shortMessageHtmlLink":"MDEV-32424 Crash in subselect engine"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAERSq2bQA","startCursor":null,"endCursor":null}},"title":"Activity · MariaDB/server"}