-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Git hooks for contributors #80
Comments
Might not be such a good idea to have generate.py to setup the dev environment, because it would require generalpackager to be installed.
It's basically what happens in the sync stage of the workflow as well. Running it once will enable the pre-push hook to run it automatically, but only important (non-aesthetic) files To summarize,
The linting should probably be included in all of these places |
Since the
.git
folder isn't versioned for security reasons to execute arbitrary code we have an issue;pre-commit
andpre-push
hooks won't be there when forked or cloned.Options
generate.py
to create all hooks for us - already implementedpre-commit install
command somewhere, insidegenerate_localfiles
or make a new method probably coupled togeneralpackager/generalpackager/packager_files.py
Line 7 in bd361ec
generate_localfiles
step in.pre-commit-config.yaml
as a pre-commit repo perhaps?I don't want developers to have to write
pre-commit install
. Everything should go throughgenerate.py
- I like it especially because it's very transparent for devs to look through the python code before running the fileThe text was updated successfully, but these errors were encountered: