Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redesign the Running Status code #1

Open
Madsy opened this issue Mar 21, 2017 · 0 comments
Open

Redesign the Running Status code #1

Madsy opened this issue Mar 21, 2017 · 0 comments
Labels

Comments

@Madsy
Copy link
Owner

Madsy commented Mar 21, 2017

The way we handle Running Status is ugly and probably buggy. For example, if a corrupt stream starts with channel event without a status byte (MSB not set), then whatever initial state stored in MidiEventFactory::previousChannelEventCode is used. We need to store a state which tells whether MidiEventFactory::previousChannelEventCode is initialized by a previous full midi channel event. Also, by storing an "is-initialized state", we can detect errors in the MIDI file. Running Status is reset by System Common messages ( but not Real Time Category messages). Hence, a channel event without a status byte right after a common message is an error.

@Madsy Madsy added the bug label Mar 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant