Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calculating item price via details page is incorrect #23

Closed
MaX-Lo opened this issue Jul 26, 2019 · 0 comments
Closed

Calculating item price via details page is incorrect #23

MaX-Lo opened this issue Jul 26, 2019 · 0 comments
Labels
bug Something isn't working

Comments

@MaX-Lo
Copy link
Owner

MaX-Lo commented Jul 26, 2019

If a item has no price we try to get that price via the details page by simply looking for the string behind "Summe:". This results in:

  • not checking for discounts which are subtracted afterwards
  • setting the full order price for a item when having multiple items in an order is very wrong
  • setting the price as string instead of float is inconsistent with normal prices being floats
@MaX-Lo MaX-Lo added the bug Something isn't working label Jul 26, 2019
@MaX-Lo MaX-Lo closed this as completed Jul 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant