Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dsharp.exe Windows binary throws error #91

Closed
plison opened this issue Sep 27, 2022 · 4 comments
Closed

dsharp.exe Windows binary throws error #91

plison opened this issue Sep 27, 2022 · 4 comments

Comments

@plison
Copy link

plison commented Sep 27, 2022

Thanks for the nice work with ProbLog! When trying to run ProbLog on Windows, I get an error with the dsharp.exe binary:
image

I'm running Windows 10, with the latest version of Problog (2.2.3).

This error is a bit annoying since it seems that the PySDD library cannot apparently be compiled on Windows. And recompiling dsharp from https://github.com/QuMuLab/dsharp/ on Windows does not seem straightforward either...

Everything runs fine when running ProbLog on Linux, however.

@VincentDerk
Copy link
Collaborator

VincentDerk commented Sep 28, 2022

Hi,

  1. Which conda version are you using? conda --v

  2. Does the .exe within this .zip work?
    Temporarily replace the dsharp.exe in the bin folder with the one in here: dsharp_static.zip (rename it to dsharp.exe instead of dsharp_static.exe)

@plison
Copy link
Author

plison commented Sep 28, 2022

Thanks! I'm using conda 4.12. Yes, when using the dsharp.exe executable in the ZIP file, the error disappears, and ProbLog seems to run without problems :-)

@VincentDerk
Copy link
Collaborator

VincentDerk commented Sep 28, 2022

Hmm.. I thought perhaps this was related to conda shipping a libstdc++ that did not contain throw_bad_array_new_lengthv [1,2], but that was supposedly fixed in conda 4.10.3. Either way it might be easiest to just use a statically compiled dsharp instead (like the one in the zip). Unless someone has a better proposal, I will replace the executable in the next ProbLog release.

[1] conda/conda#10757 (comment)
[2] stan-dev/pystan#294

Edit: Alternatively, maybe the libdstdc++ we included is outdated.

@plison
Copy link
Author

plison commented Sep 28, 2022

Yes, the statically compiled Windows executable is anyway quite small (3 MB, compared to 0.5 MB for the dynamically linked one), so it might indeed make more sense to ship ProbLog with that one.

@plison plison closed this as completed Sep 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants