Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve nested prototype definitions #3

Open
MCStreetguy opened this issue Sep 30, 2019 · 1 comment
Open

Improve nested prototype definitions #3

MCStreetguy opened this issue Sep 30, 2019 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@MCStreetguy
Copy link
Owner

Describe the bug
Currently, if the debugger encounters a nested prototype definition it cannot handle it properly. Instead, the meta key containing these definitions remains in the otherwise flattened debug-view. This is no real issue as the overview is still correct, but as the information is unstyled it looks really messy...

We have not found a clear remedy to this problem currently. See our thoughts on this below:

  • One option would be to include modified properties if the corresponding prototype is used somewhere below the current level. This could be problematic as nested definitions also apply to furtherly nested prototypes and we would need to pass them around between recursions, which will most likely result in unexpected behaviour in some way.
  • Another possibility would be to append the modifications to the internal prototype definitions but this would introduce a whole new world of complexity, as we would need to differ between nesting-levels within protoype definitions and this would either be very time- or resource-expensive!
  • The third solution would be to simply keep the information where it is, but to style it in some way (colorization, etc.) to make it at least prettier if we cannot integrate it reasonably.

To Reproduce
Steps to reproduce the behavior:

  1. Create some prototype definition
  2. Create a nested prototype definition inside of the freshly created prototype
  3. Have a look at the debug-view of the topmost new prototype

Expected behavior
Nested definitions should not be ignored totally.

Environment (please complete the following information):

  • OS: Ubuntu 16.04
  • Terminal: Bash
  • PHP: 7.0.33-0ubuntu0.16.04.5
  • Flow: v4.3.19
  • Neos: v3.3.24
@MCStreetguy MCStreetguy added the bug Something isn't working label Sep 30, 2019
@MCStreetguy MCStreetguy self-assigned this Sep 30, 2019
@MCStreetguy MCStreetguy added this to the 1.0 milestone Sep 30, 2019
@MCStreetguy MCStreetguy removed this from the Initial Release milestone Oct 13, 2020
@MCStreetguy
Copy link
Owner Author

Lowering precedence on this issue, as it's not a technical problem and there has been no conclusion to this in a long time. Not closing the issue though, as this might be fixed later on.

@MCStreetguy MCStreetguy added enhancement New feature or request and removed bug Something isn't working labels Oct 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant