Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BugFix: CNRFC Deterministic Forecast dateheader #79

Merged
merged 3 commits into from
Jan 24, 2023
Merged

BugFix: CNRFC Deterministic Forecast dateheader #79

merged 3 commits into from
Jan 24, 2023

Conversation

CAbrahamMBK
Copy link
Contributor

Fixes error from dateheader.
Sample test:

from collect import cnrfc
df = cnrfc.get_deterministic_forecast('FOLC1')

@CAbrahamMBK CAbrahamMBK added the bug Something isn't working label Jan 24, 2023
@CAbrahamMBK
Copy link
Contributor Author

I tested for [FOLSOM, BULLARDS, CAMPFARWEST, EXCHEQUER, OROVILLE, SHASTA]. I think the CNRFC just changed their table template.

@narlesky narlesky added the needs rebase pretty much ready to merge, but out of date with main label Jan 24, 2023
@CAbrahamMBK CAbrahamMBK merged commit b185b1a into main Jan 24, 2023
@narlesky narlesky deleted the cnrfc-dateheader-bug branch February 14, 2023 01:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@narlesky narlesky narlesky approved these changes

Assignees
No one assigned
Labels
bug Something isn't working needs rebase pretty much ready to merge, but out of date with main
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CAbrahamMBK @narlesky