Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bf 83 Edit Create Account Page #64

Merged
merged 18 commits into from
Dec 28, 2022
Merged

Bf 83 Edit Create Account Page #64

merged 18 commits into from
Dec 28, 2022

Conversation

Deffo0
Copy link
Member

@Deffo0 Deffo0 commented Dec 28, 2022 •
edited
Loading

FrontEnd Part

  • modify the signup page to get gender, weight, height, and birthdate through:
    • create a date field widget to be responsible of manage the date picker widget and the specs of the input field.
    • create a gender picker widget to manage the display of the user gender and take into consideration only two genders as input .
    • control all input fields to be sent after submitting.
    • modify the body of the post request.

BackEnd Part

  • add the user entity.
  • add the user repo.
  • prepare JPA named queries to get the user record by name or id.
  • modify the auth controller and the user authenticator to create a new record for the new user upon creating account post request.

DB Part

  • add new columns in the database for weight, height, gender and birthdate.

Images

image
IMG_20221228_171843

@Deffo0
BF-16
1711414 
- add the setting page with

- modify the material app for dark and light mode

- propagate the themes manually to each widget and page

- work on dark mode toggle and system is the default
@Deffo0
BF-16
9fdb393 
- finish the dark mode toggle successfully
@Deffo0
BF-16
3be52d4 
- add the svg img to the search page successfully
@Deffo0
BF-16
4c0da1c 
- remove redundant screenshot
@Deffo0
BF-16
ddef30c 
- add use system default option in settings
@Deffo0
BF-16
5368395 
- make the splash screen compatiable with the modes
@Deffo0
BF-16
d698112 
- remove redundant packages
@Deffo0
BF-16
6d1e7a6
@Deffo0
Merge branch 'BF-83-Edit-Create-Account-Page' of https://github.com/M…
fbc5959 
…AMA-LY/Recipe-Recommender into BF-83-Edit-Create-Account-Page
@Deffo0
BF-83
9042797 
- add the functionality of getting more info from users

- add some icons with the inputs to enhance the user experience

- edit the api call to post the updated info about the user
@Deffo0
BF-83
e72baa7 
- add the gender selection feature in signup page

- create the user entity in the backend

- add additional columns to the database schema

add the user repo in the backend

- modify the AuthController and UserAuthenticator to save a user instance with every successful signup in the database
@Deffo0
BF-83
4aefbea 
- modify the type of the date
@Deffo0
BF-83
1fb6480 
- set the nulls
@Deffo0
BF-83
8db8e5b 
- modify the casting of the date
@Deffo0
BF-83
6340f48 
- remove test module
@Deffo0 Deffo0 added the enhancement New feature or request label Dec 28, 2022
@Deffo0 Deffo0 linked an issue Dec 28, 2022 that may be closed by this pull request
Missing data inputs in the sign up page #38
Closed
@Deffo0 Deffo0 added this to the Milestone 3 milestone Dec 28, 2022
@Deffo0 Deffo0 changed the base branch from main to Milestone3 December 28, 2022 15:08
@Deffo0 Deffo0 changed the title Bf 83 edit create account page Bf 83 Edit Create Account Page Dec 28, 2022
@Deffo0 Deffo0 temporarily deployed to Production December 28, 2022 15:18 — with GitHub Actions Inactive
@Deffo0 Deffo0 temporarily deployed to Production December 28, 2022 15:34 — with GitHub Actions Inactive
@Deffo0 Deffo0 temporarily deployed to Production December 28, 2022 16:20 — with GitHub Actions Inactive
AbdelrahmanMosly
AbdelrahmanMosly requested changes Dec 28, 2022
View reviewed changes
Copy link
Collaborator

@AbdelrahmanMosly AbdelrahmanMosly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is all fields required before sign up?

@Deffo0 Deffo0 temporarily deployed to Production December 28, 2022 17:54 — with GitHub Actions Inactive
@Deffo0
Copy link
Member Author

Deffo0 commented Dec 28, 2022

Is all fields required before sign up?

It will not give the user a successful creation

@AbdelrahmanMosly AbdelrahmanMosly merged commit 85454ec into Milestone3 Dec 28, 2022
@AbdelrahmanMosly AbdelrahmanMosly mentioned this pull request Jan 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AbdelrahmanMosly AbdelrahmanMosly AbdelrahmanMosly approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
Milestone 3
Development

Successfully merging this pull request may close these issues.

Missing data inputs in the sign up page
2 participants
@Deffo0 @AbdelrahmanMosly