Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement : Spring integration ? #32

Open
Indy79 opened this issue Apr 14, 2021 · 3 comments
Open

Enhancement : Spring integration ? #32

Indy79 opened this issue Apr 14, 2021 · 3 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@Indy79
Copy link

Indy79 commented Apr 14, 2021

Hello, have you planned to add a spring integration (like Izanami), i'm not thinking about some magic annotations, but just an auto-configure that create some beans and make the integration straight forward.

I've created a demo project for my company and the integration is quite easy, but a little auto-configuration would make it easier and add a first "good impression" 😄

@ptitFicus
Copy link
Member

Hello, sorry for the late response.

We actually use Thoth in Spring(boot) in some of our projects, and the sample application (https://github.com/MAIF/thoth/tree/master/sample) is made with Spring.

However I suppose we could do more to ease SpringBoot integration, and your idea of a "starter" with some auto-configuration is an option. What would you auto-configure with such a starter ? I'm thinking of database / kafka connection, and perhaps some automatic wiring.

We could add it in our backlog, however if it's something you'd like to work on feel free to indicate it, and I'll assign you the issue.

@larousso what do you think ?

@larousso
Copy link
Contributor

That could be great !

@Indy79
Copy link
Author

Indy79 commented May 20, 2021

@ptitFicus I was thinking about datasource (connection and transaction manager), kafka, executorService and actorSystem.

I've already try something, it's just a "proof of concept" but it show the main approach i was thinking about (it may not work, i didn't have the time to try as i'm in vacation 😄)

https://github.com/Indy79/thoth/tree/feat/springboot-integration

@ptitFicus ptitFicus added enhancement New feature or request help wanted Extra attention is needed labels Jul 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants