Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build fails with new scikit-learn release 1.4.0 #524

Closed
MLecardonnel opened this issue Jan 25, 2024 · 1 comment · Fixed by #543
Closed

Build fails with new scikit-learn release 1.4.0 #524

MLecardonnel opened this issue Jan 25, 2024 · 1 comment · Fixed by #543
Assignees
@MLecardonnel

Comments

@MLecardonnel
Copy link
Collaborator

Shapash computes _iter method from ColumnTransformer without the required parameters that used to be optional:
https://github.com/scikit-learn/scikit-learn/pull/27005/files#diff-fea489154c629a45ec01030d191f20465e809124a24260ac35fb884bc855140fR365
Changes are needed.
@guerinclement
Copy link
Collaborator

Quickly fixed by #521
scikit-learn version is limited to <1.4

@MLecardonnel MLecardonnel self-assigned this Mar 7, 2024
@MLecardonnel MLecardonnel mentioned this issue Mar 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MLecardonnel MLecardonnel

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Scikit learn fix for versions above 1.4.0 MLecardonnel/shapash
2 participants
@guerinclement @MLecardonnel