Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong Lychee version for Version 5.1.1 .zip file #2235

Closed
LudovicRousseau opened this issue Jan 22, 2024 · 6 comments
Closed

Wrong Lychee version for Version 5.1.1 .zip file #2235

LudovicRousseau opened this issue Jan 22, 2024 · 6 comments

Comments

@LudovicRousseau
Copy link

Detailed description of the problem

The archive .zip file provides the file version.md which contains:

$ cat version.md 
5.1.0

I would expect 5.1.1 instead.

Steps to reproduce the issue

  1. download https://github.com/LycheeOrg/Lychee/releases/download/v5.1.1/Lychee.zip
  2. extract the files
  3. see by yourself
@ildyria
Copy link
Member

ildyria commented Jan 22, 2024

WTF.

@LudovicRousseau
Copy link
Author

It is strange because the change 5.1.0 to 5.1.1 is listed in v5.1.0...v5.1.1

@ildyria
Copy link
Member

ildyria commented Jan 22, 2024

Fixed. Thank you.

Yeah the zip file is attached manually to the release. It seems that my github refused to do git pull 3 times for no reason. Should be fix now.

@LudovicRousseau
Copy link
Author

I have the problem with the Lychee.zip file but NOT with the Source code (zip) file.

@ildyria
Copy link
Member

ildyria commented Jan 22, 2024

...
  adding: Lychee/vendor/maennchen/zipstream-php/.phpdoc/template/base.html.twig (deflated 61%)
  adding: Lychee/vendor/maennchen/zipstream-php/.editorconfig (deflated 53%)
  adding: Lychee/vendor/maennchen/zipstream-php/LICENSE (deflated 41%)
  adding: Lychee/vendor/maennchen/zipstream-php/psalm.xml (deflated 55%)
  adding: Lychee/vendor/maennchen/zipstream-php/README.md (deflated 68%)
  adding: Lychee/scripts/ (stored 0%)
  adding: Lychee/scripts/install_files.php (deflated 52%)
  adding: Lychee/scripts/post-merge (deflated 67%)
  adding: Lychee/scripts/pre-commit (deflated 57%)
  adding: Lychee/scripts/gen_release.php (deflated 61%)

Documents/Projects/Lychee-dist  master ✗                                                                                                                                                      1h13m ⚑ ◒  
▶ cat version.md
5.1.1%                                

@ildyria ildyria closed this as completed Jan 22, 2024
@ildyria
Copy link
Member

ildyria commented Jan 22, 2024

thank you for the quick heads up!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants