Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

better diagnostics #2142

Merged
merged 1 commit into from
Jan 1, 2024
Merged

better diagnostics #2142

merged 1 commit into from
Jan 1, 2024

Conversation

ildyria
Copy link
Member

@ildyria ildyria commented Jan 1, 2024

Fixes #2121

Add new possible messages:

If APP_URL is not provided.

  • Warning: APP_URL is still set to default, this will break access to all your images and assets if you are using Lychee behind a sub-domain

If using a subpath:

  • Warning: APP_URL (lyc******st/te******url) contains a sub-path (/te******url). This may impact your WebAuthn authentication.
  • Error: APP_URL (lyc******st/te******url) does not match the current url (https://lyc******st). This will break WebAuthn authentication.
  • Error: APP_URL (lyc******st/te******url) does not match the current url (https://lyc******st). This will prevent images to be properly displayed.

@ildyria ildyria requested a review from a team January 1, 2024 15:53
@ildyria ildyria added the Review: easy Easy review expected: probably just need a quick to go through. label Jan 1, 2024
@ildyria ildyria added this to the 5.0.3 milestone Jan 1, 2024
@ildyria ildyria merged commit 6c36ef9 into master Jan 1, 2024
33 checks passed
@ildyria ildyria deleted the improve-url-feedback branch January 1, 2024 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Review: easy Easy review expected: probably just need a quick to go through.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] Error: APP_URL does not match the current url. This will break WebAuthn authentication.
2 participants