Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark unexported symbols as public #712

Merged
merged 1 commit into from
Jun 17, 2024
Merged

Mark unexported symbols as public #712

merged 1 commit into from
Jun 17, 2024

Conversation

avik-pal
Copy link
Member

No description provided.

@avik-pal avik-pal merged commit add0639 into main Jun 17, 2024
34 of 44 checks passed
@avik-pal avik-pal deleted the ap/public branch June 17, 2024 04:36
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark Results

Benchmark suite Current: 74dbea3 Previous: 500ce6e Ratio
Dense(2 => 2)/cpu/reverse/ReverseDiff (compiled)/(2, 128) 3678 ns 3670.625 ns 1.00
Dense(2 => 2)/cpu/reverse/Zygote/(2, 128) 7240.166666666667 ns 7170 ns 1.01
Dense(2 => 2)/cpu/reverse/Tracker/(2, 128) 21420 ns 20769 ns 1.03
Dense(2 => 2)/cpu/reverse/ReverseDiff/(2, 128) 9866.4 ns 9808.6 ns 1.01
Dense(2 => 2)/cpu/reverse/Flux/(2, 128) 9098.8 ns 9057 ns 1.00
Dense(2 => 2)/cpu/reverse/SimpleChains/(2, 128) 4484.625 ns 4458.375 ns 1.01
Dense(2 => 2)/cpu/reverse/Enzyme/(2, 128) 1170.404255319149 ns 1156.63309352518 ns 1.01
Dense(2 => 2)/cpu/forward/NamedTuple/(2, 128) 1180.8666666666666 ns 1116.3910256410256 ns 1.06
Dense(2 => 2)/cpu/forward/ComponentArray/(2, 128) 1183.3823529411766 ns 1161.716535433071 ns 1.02
Dense(2 => 2)/cpu/forward/Flux/(2, 128) 1814.4888888888888 ns 1786.5762711864406 ns 1.02
Dense(2 => 2)/cpu/forward/SimpleChains/(2, 128) 180.23783031988873 ns 180.16946778711485 ns 1.00
Dense(20 => 20)/cpu/reverse/ReverseDiff (compiled)/(20, 128) 17342 ns 17303 ns 1.00
Dense(20 => 20)/cpu/reverse/Zygote/(20, 128) 16972 ns 16842 ns 1.01
Dense(20 => 20)/cpu/reverse/Tracker/(20, 128) 39904 ns 37350 ns 1.07
Dense(20 => 20)/cpu/reverse/ReverseDiff/(20, 128) 29555 ns 29465 ns 1.00
Dense(20 => 20)/cpu/reverse/Flux/(20, 128) 20177 ns 20008 ns 1.01
Dense(20 => 20)/cpu/reverse/SimpleChains/(20, 128) 17562.5 ns 17302 ns 1.02
Dense(20 => 20)/cpu/reverse/Enzyme/(20, 128) 4341 ns 4326.714285714285 ns 1.00
Dense(20 => 20)/cpu/forward/NamedTuple/(20, 128) 3817.125 ns 3881 ns 0.98
Dense(20 => 20)/cpu/forward/ComponentArray/(20, 128) 3926 ns 3971.25 ns 0.99
Dense(20 => 20)/cpu/forward/Flux/(20, 128) 4820.428571428572 ns 4939.285714285715 ns 0.98
Dense(20 => 20)/cpu/forward/SimpleChains/(20, 128) 1660.1 ns 1661.2 ns 1.00
Conv((3, 3), 3 => 3)/cpu/reverse/ReverseDiff (compiled)/(64, 64, 3, 128) 40825253 ns 39566002 ns 1.03
Conv((3, 3), 3 => 3)/cpu/reverse/Zygote/(64, 64, 3, 128) 57736098.5 ns 57817186.5 ns 1.00
Conv((3, 3), 3 => 3)/cpu/reverse/Tracker/(64, 64, 3, 128) 81252613 ns 76439301.5 ns 1.06
Conv((3, 3), 3 => 3)/cpu/reverse/ReverseDiff/(64, 64, 3, 128) 91841744 ns 89230208 ns 1.03
Conv((3, 3), 3 => 3)/cpu/reverse/Flux/(64, 64, 3, 128) 77570237.5 ns 72947797 ns 1.06
Conv((3, 3), 3 => 3)/cpu/reverse/SimpleChains/(64, 64, 3, 128) 11826991 ns 12283939 ns 0.96
Conv((3, 3), 3 => 3)/cpu/reverse/Enzyme/(64, 64, 3, 128) 8461945 ns 18266174 ns 0.46
Conv((3, 3), 3 => 3)/cpu/forward/NamedTuple/(64, 64, 3, 128) 7039065.5 ns 7087651.5 ns 0.99
Conv((3, 3), 3 => 3)/cpu/forward/ComponentArray/(64, 64, 3, 128) 6962513 ns 7053892 ns 0.99
Conv((3, 3), 3 => 3)/cpu/forward/Flux/(64, 64, 3, 128) 12112555.5 ns 10037590.5 ns 1.21
Conv((3, 3), 3 => 3)/cpu/forward/SimpleChains/(64, 64, 3, 128) 6401639 ns 6385632.5 ns 1.00
vgg16/cpu/reverse/Zygote/(32, 32, 3, 16) 774155746 ns 744192429 ns 1.04
vgg16/cpu/reverse/Zygote/(32, 32, 3, 64) 2600328668 ns 2529267648 ns 1.03
vgg16/cpu/reverse/Zygote/(32, 32, 3, 2) 134664742.5 ns 133990620 ns 1.01
vgg16/cpu/reverse/Tracker/(32, 32, 3, 16) 899782753 ns 856466066 ns 1.05
vgg16/cpu/reverse/Tracker/(32, 32, 3, 64) 3189324294 ns 2915702638 ns 1.09
vgg16/cpu/reverse/Tracker/(32, 32, 3, 2) 228314420 ns 190288122 ns 1.20
vgg16/cpu/reverse/Flux/(32, 32, 3, 16) 746565751 ns 688070141 ns 1.09
vgg16/cpu/reverse/Flux/(32, 32, 3, 64) 3012508548 ns 2648522858 ns 1.14
vgg16/cpu/reverse/Flux/(32, 32, 3, 2) 126386088 ns 133940212 ns 0.94
vgg16/cpu/forward/NamedTuple/(32, 32, 3, 16) 174378311.5 ns 174835827.5 ns 1.00
vgg16/cpu/forward/NamedTuple/(32, 32, 3, 64) 656927377 ns 645332934 ns 1.02
vgg16/cpu/forward/NamedTuple/(32, 32, 3, 2) 34507920.5 ns 45844367 ns 0.75
vgg16/cpu/forward/ComponentArray/(32, 32, 3, 16) 164989992 ns 164919695.5 ns 1.00
vgg16/cpu/forward/ComponentArray/(32, 32, 3, 64) 646493795 ns 643636841 ns 1.00
vgg16/cpu/forward/ComponentArray/(32, 32, 3, 2) 30711458 ns 30301490 ns 1.01
vgg16/cpu/forward/Flux/(32, 32, 3, 16) 212836194 ns 205859449.5 ns 1.03
vgg16/cpu/forward/Flux/(32, 32, 3, 64) 786615528 ns 711150021 ns 1.11
vgg16/cpu/forward/Flux/(32, 32, 3, 2) 36394715 ns 37960867 ns 0.96
Conv((3, 3), 64 => 64)/cpu/reverse/ReverseDiff (compiled)/(64, 64, 64, 128) 1212485361.5 ns 1240278369.5 ns 0.98
Conv((3, 3), 64 => 64)/cpu/reverse/Zygote/(64, 64, 64, 128) 1866384274.5 ns 1871750095 ns 1.00
Conv((3, 3), 64 => 64)/cpu/reverse/Tracker/(64, 64, 64, 128) 2405394158 ns 2304779837 ns 1.04
Conv((3, 3), 64 => 64)/cpu/reverse/ReverseDiff/(64, 64, 64, 128) 2499819503 ns 2474043096 ns 1.01
Conv((3, 3), 64 => 64)/cpu/reverse/Flux/(64, 64, 64, 128) 1941307620.5 ns 1812136576.5 ns 1.07
Conv((3, 3), 64 => 64)/cpu/reverse/Enzyme/(64, 64, 64, 128) 355965168 ns 558749714 ns 0.64
Conv((3, 3), 64 => 64)/cpu/forward/NamedTuple/(64, 64, 64, 128) 325783420 ns 313383451 ns 1.04
Conv((3, 3), 64 => 64)/cpu/forward/ComponentArray/(64, 64, 64, 128) 323533607 ns 318846679 ns 1.01
Conv((3, 3), 64 => 64)/cpu/forward/Flux/(64, 64, 64, 128) 359938393 ns 405806236.5 ns 0.89
Conv((3, 3), 1 => 1)/cpu/reverse/ReverseDiff (compiled)/(64, 64, 1, 128) 11938102 ns 12061919 ns 0.99
Conv((3, 3), 1 => 1)/cpu/reverse/Zygote/(64, 64, 1, 128) 17787630 ns 17848949 ns 1.00
Conv((3, 3), 1 => 1)/cpu/reverse/Tracker/(64, 64, 1, 128) 19055984 ns 19097389 ns 1.00
Conv((3, 3), 1 => 1)/cpu/reverse/ReverseDiff/(64, 64, 1, 128) 23861769 ns 23808385.5 ns 1.00
Conv((3, 3), 1 => 1)/cpu/reverse/Flux/(64, 64, 1, 128) 17818299 ns 17792638.5 ns 1.00
Conv((3, 3), 1 => 1)/cpu/reverse/SimpleChains/(64, 64, 1, 128) 1165204 ns 1166213 ns 1.00
Conv((3, 3), 1 => 1)/cpu/reverse/Enzyme/(64, 64, 1, 128) 2523677 ns 5885370 ns 0.43
Conv((3, 3), 1 => 1)/cpu/forward/NamedTuple/(64, 64, 1, 128) 2050387 ns 2057561 ns 1.00
Conv((3, 3), 1 => 1)/cpu/forward/ComponentArray/(64, 64, 1, 128) 2032955 ns 2032929 ns 1.00
Conv((3, 3), 1 => 1)/cpu/forward/Flux/(64, 64, 1, 128) 2077036.5 ns 2076976.5 ns 1.00
Conv((3, 3), 1 => 1)/cpu/forward/SimpleChains/(64, 64, 1, 128) 199401 ns 199575 ns 1.00
Dense(200 => 200)/cpu/reverse/ReverseDiff (compiled)/(200, 128) 295791 ns 293621 ns 1.01
Dense(200 => 200)/cpu/reverse/Zygote/(200, 128) 269617 ns 266003.5 ns 1.01
Dense(200 => 200)/cpu/reverse/Tracker/(200, 128) 374126 ns 367151.5 ns 1.02
Dense(200 => 200)/cpu/reverse/ReverseDiff/(200, 128) 412268 ns 409057.5 ns 1.01
Dense(200 => 200)/cpu/reverse/Flux/(200, 128) 276976 ns 274845.5 ns 1.01
Dense(200 => 200)/cpu/reverse/SimpleChains/(200, 128) 407669 ns 407115 ns 1.00
Dense(200 => 200)/cpu/reverse/Enzyme/(200, 128) 83455 ns 83356 ns 1.00
Dense(200 => 200)/cpu/forward/NamedTuple/(200, 128) 82294 ns 81453 ns 1.01
Dense(200 => 200)/cpu/forward/ComponentArray/(200, 128) 83786 ns 82124 ns 1.02
Dense(200 => 200)/cpu/forward/Flux/(200, 128) 87983.5 ns 87284 ns 1.01
Dense(200 => 200)/cpu/forward/SimpleChains/(200, 128) 104674 ns 104837 ns 1.00
Conv((3, 3), 16 => 16)/cpu/reverse/ReverseDiff (compiled)/(64, 64, 16, 128) 192752808 ns 194652677 ns 0.99
Conv((3, 3), 16 => 16)/cpu/reverse/Zygote/(64, 64, 16, 128) 325229597.5 ns 328747337.5 ns 0.99
Conv((3, 3), 16 => 16)/cpu/reverse/Tracker/(64, 64, 16, 128) 414689113 ns 388541316 ns 1.07
Conv((3, 3), 16 => 16)/cpu/reverse/ReverseDiff/(64, 64, 16, 128) 461458109.5 ns 456882676 ns 1.01
Conv((3, 3), 16 => 16)/cpu/reverse/Flux/(64, 64, 16, 128) 377925298 ns 371080365 ns 1.02
Conv((3, 3), 16 => 16)/cpu/reverse/SimpleChains/(64, 64, 16, 128) 336784813.5 ns 322888448 ns 1.04
Conv((3, 3), 16 => 16)/cpu/reverse/Enzyme/(64, 64, 16, 128) 51549866 ns 101545073 ns 0.51
Conv((3, 3), 16 => 16)/cpu/forward/NamedTuple/(64, 64, 16, 128) 44193837.5 ns 43675935 ns 1.01
Conv((3, 3), 16 => 16)/cpu/forward/ComponentArray/(64, 64, 16, 128) 43985377 ns 43493025 ns 1.01
Conv((3, 3), 16 => 16)/cpu/forward/Flux/(64, 64, 16, 128) 61473765.5 ns 49863360.5 ns 1.23
Conv((3, 3), 16 => 16)/cpu/forward/SimpleChains/(64, 64, 16, 128) 28189830 ns 28345237 ns 0.99
Dense(2000 => 2000)/cpu/reverse/ReverseDiff (compiled)/(2000, 128) 19147621 ns 18886629 ns 1.01
Dense(2000 => 2000)/cpu/reverse/Zygote/(2000, 128) 19672268 ns 19675975 ns 1.00
Dense(2000 => 2000)/cpu/reverse/Tracker/(2000, 128) 23654835 ns 23456548 ns 1.01
Dense(2000 => 2000)/cpu/reverse/ReverseDiff/(2000, 128) 24318886.5 ns 24255304 ns 1.00
Dense(2000 => 2000)/cpu/reverse/Flux/(2000, 128) 19752375 ns 19689698 ns 1.00
Dense(2000 => 2000)/cpu/reverse/Enzyme/(2000, 128) 6554490.5 ns 6529775.5 ns 1.00
Dense(2000 => 2000)/cpu/forward/NamedTuple/(2000, 128) 6601618 ns 6508346.5 ns 1.01
Dense(2000 => 2000)/cpu/forward/ComponentArray/(2000, 128) 6539783 ns 6470790 ns 1.01
Dense(2000 => 2000)/cpu/forward/Flux/(2000, 128) 6543254.5 ns 6520109 ns 1.00

This comment was automatically generated by workflow using github-action-benchmark.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant