UI & data source refactor #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
Luki120
commented
Jan 16, 2024
- Refactored all the UI to use bigger cells with spacing between them & clean good looking shadows
- Refactored the data source again to switch to MVVM
• completely refactored IssuerCell ⇝ bigger cell with clean good looking shadows, bigger issuer image, circular view & pin code + now shows the issuer's name & account labels (latter is hardcoded right now until NewIssuerVC is refactored to include a field that'll let you type the account) • IssuersDataSource is no longer a class owned by IssuersVC, rather by IssuersVCView, as the view should be the one interacting with the view model, not the view controller directly (this ain't strictly a view model yet, but it will be if the app gets refactored to use MVVM) • removed as many instance variables as possible • removed code that became obsolete with this refactor • the search & filter logic is handled now by IssuersDataSource ⇝ less loc in IssuersVC + makes more sense • UICollectionView > UITableView ™️ ⇝ gives the ability to add spacing between the cells, making it look nicer + native drag & drop, which looks better than UITableView's editing feature
• created IssuerCellViewModel & renamed IssuersDataSource to IssuersViewViewModel • fixed the issuer's index var not updating after deleting one
• created NewIssuerFormCell & NewIssuerAlgorithmCell ⇝ bigger cell with nice clean shadows & corner radius • switched to MVVM to handle the data
• renamed ModalSheetDataSource to ModalChildViewViewModel + created view models for NewIssuerOptionsCell & NewIssuerOptionsHeaderView ⇝ MVVM
• better layout structure • renamed ModalChildViewViewModel, ModalChildView & ModalSheetVC to NewIssuerOptionsViewViewModel, NewIssuerOptionsView & NewIssuerOptionsVC respectively
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.