From f759792e0855281c38f5efd45952701d85048c5a Mon Sep 17 00:00:00 2001 From: Jakub Jelen Date: Thu, 30 May 2019 09:58:23 +0200 Subject: [PATCH] configfile: Avoid memory leaks in case of realloc failure (cppcheck warning) The original patch was written by Bob Relyea for RHEL package, but I tweaked it a bit to make sure it builds without warnings. Signed-off-by: Jakub Jelen --- src/configfile.l | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/src/configfile.l b/src/configfile.l index 63397e3b..8a7edb74 100644 --- a/src/configfile.l +++ b/src/configfile.l @@ -216,9 +216,18 @@ int evaluatetoken(char *pcToken) } else { + SerialReader *new_reader_list = NULL; reader_list_size++; - reader_list = realloc(reader_list, reader_list_size * + new_reader_list = realloc(reader_list, reader_list_size * sizeof(SerialReader)); + if (new_reader_list == NULL) + free(reader_list); + reader_list = new_reader_list; + } + if (reader_list == NULL) + { + tok_error("No Memory"); + return 1; } /* end marker */