IFDStatusICC returns SCARD_S_SUCCESS after the reader is removed

[andrei-datcu]

Ever since this patch IFDStatusICC returns SCARD_S_SUCESS if the read fails. That's because IFDHICCPresence doesn't return IFD_NO_SUCH_DEVICE anymore. Upon a static code inspection, this means that nobody will ever set SCARD_UNKNOWN because the status handler thread get a success from IFDStatusICC

[LudovicRousseau]

I can't find SCARD_UKNOWN in the source code.

What is the problem exactly?

[andrei-datcu]

Sorry, it was a typo: SCARD_UNKNOWN. Edited.

Basically a waiter for SCardGetStatus will not get a result when the reader is removed

[LudovicRousseau]

SCardGetStatusChange() instead SCardGetStatus()?

Have you tried to reproduce the bug with a sample code?

[LudovicRousseau]

@andrei-datcu any news about this problem?

[andrei-datcu]

Sorry, no repro on hand, but please allow me to expand on the static analysis:

Ever since this change, IFDHICCPresence will not return IFD_NO_SUCH_DEVICE.

This means that this code is now dead and no longer executes.
Finally, the event thread which sits at the bottom of this call stack will get a SCARD_S_SUCCESS and the status a SCARD_ABSENT flag. Up until the aforementioned patch, the thread would get a SCARD_E_READER_UNAVAILABLE and the status would be SCARD_UNKNOWN.

[LudovicRousseau]

I guess you are right.

What is the problem at the PC/SC API level? Do you have a sample code to show this problem?

[LudovicRousseau]

The code https://github.com/LudovicRousseau/PCSC/blob/210efa525f50e99821a10d91b8c861825e470d8b/src/ifdwrapper.c#L369 is not used only when you use the CCID driver. Other drivers may still report IFD_NO_SUCH_DEVICE when the reader is removed.

Unless you can show a real PC/SC application sample code with a problem I consider this as a non-issue and close it.