Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STAT: Composed names are sometimes including elided axis values #54

Open
m4rc1e opened this issue Oct 23, 2020 · 3 comments
Open

STAT: Composed names are sometimes including elided axis values #54

m4rc1e opened this issue Oct 23, 2020 · 3 comments

Comments

@m4rc1e
Copy link

m4rc1e commented Oct 23, 2020

I've noticed Samsa is including an elided Axis Value in the STAT's composed name field for a VF family which consists of two fonts, Roman and Italic.

Screenshot 2020-10-23 at 10 58 40

If I ttx the font, I can see the Axis Value is elided (I know this Axis Value should't be a format 2)

        <AxisIndex value="1"/>
        <Flags value="2"/>
        <ValueNameID value="271"/>  <!-- Roman -->
        <NominalValue value="0.0"/>
        <RangeMinValue value="0.0"/>
        <RangeMaxValue value="0.0"/>
      </AxisValue>

mulish_split.zip

@m4rc1e
Copy link
Author

m4rc1e commented Oct 23, 2020

I just converted the offending Axis Values to format 1 and it works just fine.

Screenshot 2020-10-23 at 11 05 59

cc @yanone

@Lorp
Copy link
Owner

Lorp commented Oct 23, 2020

The square bracket (at the end of the elided name in your first message) indicates that your axis is not exactly on the nominal value of Roman. In these cases, Samsa is designed to include the name with the value appended in square brackets, e.g. “Roman[401]” or “Medium[588.22]”. Only when it’s exactly on the nominal value will an elided name drop out from a composed name.

Methods for composing names from arbitrary designspace locations are not in the spec, so Samsa and Adobe CC apps make their own rules.

@m4rc1e
Copy link
Author

m4rc1e commented Oct 23, 2020

I'm getting this issue when I'm selecting the Axis Values from the STAT panel, I'm not using the Axes slider. If I'm selecting an Axis Value from the STAT menu, I'd expect to get the nominal value back if the Axis Value is a Format 2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants