Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Video is added on not executed tests #149

Closed
irapths opened this issue Jun 7, 2023 · 3 comments · Fixed by #150
Closed

Video is added on not executed tests #149

irapths opened this issue Jun 7, 2023 · 3 comments · Fixed by #150
Labels
bug Something isn't working

Comments

@irapths
Copy link

irapths commented Jun 7, 2023

Environment

- OS: All
- Node: 
- cypress-mochawesome-reporter: 3.5.0
- cypress:

What happened?

The video is added as Additional Test Context on not executed (SKEPped) tests.

Moreover, using the new option videoOnFailOnly (#141) and set it to true does not prevent videos to be added on SKIPped tests.

Config file

Default settings

OR

videoOnFailOnly: true

Relevant log output

No response

Anything else?

The addition of video as Additional Test Context on tests is a great feature.

But I think it should be added only on executed tests (PASSed or FAILed) and not on SKIPped.
Additionaly the option videoOnFailOnly: true should add video only on FAILed tests and prevent the video to be added on all others.

@irapths irapths added the bug Something isn't working label Jun 7, 2023
@joakim-sch
Copy link
Contributor

Hi @irapths !
Thank you for your feedback. Glad you enjoyed the video feature 😄 🎥
The logic is just looking at not passed tests when videoOnFailOnly: true so there is definitely logic for skipped tests missing... Should be an easy fix tho 😃

@joakim-sch
Copy link
Contributor

I have created PR #150 that should fix the issue ✌🏼

@LironEr
Copy link
Owner

LironEr commented Jun 15, 2023

Fixed in v3.5.1
Thanks @joakim-sch and @irapths

@LironEr LironEr closed this as completed Jun 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants