From d01b8cd32abd04d422b4b198901f3de206c051c6 Mon Sep 17 00:00:00 2001 From: Daniel Karrasch Date: Mon, 26 Jun 2023 11:06:22 +0200 Subject: [PATCH] Add type assertion to inner HermOrSym constructor (#50282) --- stdlib/LinearAlgebra/src/symmetric.jl | 4 ++-- stdlib/LinearAlgebra/test/symmetric.jl | 3 +++ 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/stdlib/LinearAlgebra/src/symmetric.jl b/stdlib/LinearAlgebra/src/symmetric.jl index 1fc0c6aa0d94d..fa3464e93230b 100644 --- a/stdlib/LinearAlgebra/src/symmetric.jl +++ b/stdlib/LinearAlgebra/src/symmetric.jl @@ -5,7 +5,7 @@ struct Symmetric{T,S<:AbstractMatrix{<:T}} <: AbstractMatrix{T} data::S uplo::Char - function Symmetric{T,S}(data, uplo) where {T,S<:AbstractMatrix{<:T}} + function Symmetric{T,S}(data, uplo::Char) where {T,S<:AbstractMatrix{<:T}} require_one_based_indexing(data) (uplo != 'U' && uplo != 'L') && throw_uplo() new{T,S}(data, uplo) @@ -98,7 +98,7 @@ struct Hermitian{T,S<:AbstractMatrix{<:T}} <: AbstractMatrix{T} data::S uplo::Char - function Hermitian{T,S}(data, uplo) where {T,S<:AbstractMatrix{<:T}} + function Hermitian{T,S}(data, uplo::Char) where {T,S<:AbstractMatrix{<:T}} require_one_based_indexing(data) (uplo != 'U' && uplo != 'L') && throw_uplo() new{T,S}(data, uplo) diff --git a/stdlib/LinearAlgebra/test/symmetric.jl b/stdlib/LinearAlgebra/test/symmetric.jl index c901f9b2facc3..224b7b31a50df 100644 --- a/stdlib/LinearAlgebra/test/symmetric.jl +++ b/stdlib/LinearAlgebra/test/symmetric.jl @@ -64,6 +64,9 @@ end @test_throws ArgumentError Symmetric(asym, :R) @test_throws ArgumentError Hermitian(asym, :R) + @test_throws MethodError Symmetric{eltya,typeof(asym)}(asym, :L) + @test_throws MethodError Hermitian{eltya,typeof(aherm)}(aherm, :L) + # mixed cases with Hermitian/Symmetric if eltya <: Real @test Symmetric(Hermitian(aherm, :U)) === Symmetric(aherm, :U)