-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wavelet coherence order #452
Labels
bug lite
bugs that are not really bugs (won't affect results significantly)
Projects
Comments
The tau vector is calculated from the first time series, creating slightly different values. |
Thanks @khider! @shiness11 this explains the mystery. At some point we will improve the choice of a common tau vector (the time values at which the coherence is evaluated), but since it does not appear to make a material difference in most applications I've seen (including yours), this is not a high priority. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
When performing the wavelet coherence analysis on two datasets (a d13C record and eNd record from the same sediment core), the order that the timeseries are placed in the calculation gives slightly different scalograms.
To Reproduce
Steps to reproduce the behavior:
@CommonClimate has a copy of the notebook I have been working on, along with the relevant datasets. The two lines of code which should give the same result are:
coh = eNd1479_MPT.wavelet_coherence(d13C1479_MPT.flip())
and
coh = d13C1479_MPT.wavelet_coherence(eNd1479_MPT.flip())
Screenshots corresponding to lines 1 and 2 are below.
Expected behavior
Based on conversations with @CommonClimate, the function should be reversible (other than the phase, which would be of opposite sign), so it's not clear why the two scalograms look slightly different.
Screenshots
![Screen Shot 2023-07-05 at 11 56 05 AM](https://private-user-images.githubusercontent.com/23249190/251208529-af61a0e7-3156-4352-8d63-193e4a4c44f4.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjEyMjg4NjksIm5iZiI6MTcyMTIyODU2OSwicGF0aCI6Ii8yMzI0OTE5MC8yNTEyMDg1MjktYWY2MWEwZTctMzE1Ni00MzUyLThkNjMtMTkzZTRhNGM0NGY0LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA3MTclMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNzE3VDE1MDI0OVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTY2ZDdlMTRmNzJlOTU5ZDdlYzFmNzQxMjU4ZTg4NDQ4ZDNmYjExODM3NTJiMjhhMmJiOTMwMWNhMGM3MzIzNDYmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.oQHFEMK0VA1pxM1HVmAbH2aN9jvaCfu6h1dPWcncNN0)
![Screen Shot 2023-07-05 at 11 56 58 AM](https://private-user-images.githubusercontent.com/23249190/251208752-87959dd9-b558-437a-a655-1f5a46ecc999.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjEyMjg4NjksIm5iZiI6MTcyMTIyODU2OSwicGF0aCI6Ii8yMzI0OTE5MC8yNTEyMDg3NTItODc5NTlkZDktYjU1OC00MzdhLWE2NTUtMWY1YTQ2ZWNjOTk5LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA3MTclMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNzE3VDE1MDI0OVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWJiOWQ2YzRjMWMxODY2MmFhNTI1NGNkYWQ5YzQzNjQ3NDNhYzRjMGNjMzMzNTMwZTI5OTgyMGY3MmEyYzI4YjYmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.eS9_mvggcufHzKQWB3b0Frpy7t3ii_i1RhDLKCJ1cx8)
From line 1:
From line 2:
Desktop (please complete the following information):
The text was updated successfully, but these errors were encountered: