Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For sCMOS cameras, gain, offset, readnoise should be allowed to be scalars #37

Open
MJWester opened this issue May 15, 2023 · 0 comments

Comments

@MJWester
Copy link
Member

Right now, for the SCMOS CameraType, if CameraGain, CameraOffset and CameraNoise are scalars and CalibrationFilePath is empty, the algorithm can access random bits of memory, Note the comments in DataToPhotons:
% NOTE: This may be overwritten below if a calibration file
% is present and the camera type is specified as
% 'SCMOS'. If that happens, it was done on purpose!
% It's best to use the value in the calibration file
% rather than what the user has entered.

                % If no filepath is given, or if the camera is
                % specified as an EMCCD, we don't need to load a
                % calibration file.

The fix is to make a 2D array for each of these quantities of the appropriate size and set equal to the scalar value provided, probably in DataToPhotons.m

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant