-
-
Notifications
You must be signed in to change notification settings - Fork 480
/
ChangeLog
12478 lines (8463 loc) · 474 KB
/
ChangeLog
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
2022-12-18 Christian Beier <[email protected]>
* README.md: README: document Changelog update tool
2022-12-18 Christian Beier <[email protected]>
* NEWS.md: NEWS: add intro and highlights of v0.9.14 re #542
2022-12-18 Christian Beier <[email protected]>
* README.md: README: update section about server-side scaling ...as this has been tested now with UltraVNC. Closes #373
2022-12-18 Christian Beier <[email protected]>
* README.md: README: mention needed client msg for server-side
scaling re #373
2022-12-18 Christian Beier <[email protected]>
* CMakeLists.txt: CMake: set version to 0.9.14 re #542
2022-12-04 Christian Beier <[email protected]>
* webclients/novnc: webclients: update noVNC to v1.3.0
2022-12-04 Christian Beier <[email protected]>
* README.md: README: update release guidelines
2022-12-04 Christian Beier <[email protected]>
* README.md: README: fix reversed RFB operation logic
2022-12-04 Christian Beier <[email protected]>
* README.md: README: list some 'slow link' strategies re #373
2022-12-04 Christian Beier <[email protected]>
* rfb/rfb.h: docs: add TOC to LibVNCServer doxygen docu
2022-12-03 Christian Beier <[email protected]>
* NEWS.md: NEWS: update for v0.9.14
2022-12-02 Christian Beier <[email protected]>
* README.md: README: add one more release checklist item
2022-12-02 Christian Beier <[email protected]>
* AUTHORS: AUTHORS: add new contributors since v0.9.13
2022-11-13 Christian Beier <[email protected]>
* CMakeLists.txt, common/sockets.c, common/sockets.h,
libvncclient/sockets.c, rfb/rfbconfig.h.cmakein: Revert
"libvncclient: use poll() if available" This reverts commit 993df68933db378ba862af05809d6e4938333d6e. The new poll() functionality broke connecting a LibVNCServer-based
server to an RFB repeater, so reverting this for now. Closes https://github.com/bk138/droidVNC-NG/issues/109
2022-11-03 Christian Beier <[email protected]>
* cmake/Modules/FindLibSSH2.cmake: build: add FindLibSSH2.cmake Closes #539
2022-11-03 Christian Beier <[email protected]>
* .gitignore: .gitignore: don't ignore *.cmake re #539
2022-10-05 Christian Beier <[email protected]>
* README.md: README: add release checklist
2022-10-05 Christian Beier <[email protected]>
* .travis.yml: TravisCI: remove
2022-10-05 Christian Beier <[email protected]>
* README.md: README: exchange TravisCI badge with GitHub one
2022-10-05 Christian Beier <[email protected]>
* .github/workflows/ci.yml: .github: port TravisCI to GitHub
workflow
2022-10-05 Christian Beier <[email protected]>
* cmake/Toolchain-cross-mingw32-linux.cmake: CMake: default to
64-bit wine in toolchain file
2022-10-05 Christian Beier <[email protected]>
* common/sockets.c: common: fix sockets compilation w/ XCode13
2022-09-22 Tobias Junghans <[email protected]>
* libvncserver/tight.c: tight: fix OOB memory accesses As of 7124b5fbcf0df8db4d3f73023d77af6ea56409e7 the maximum rect
width and size are equal for every compression level so we can
easily save the LUT entries by using constants instead. This fixes OOB memory accesses in rfbNumCodedRectsTight() when being
called by rfbSendFramebufferUpdate() before SendRectEncodingTight()
is being called the first time (which limits cl->tightCompressLevel
to the size of tightConf).
2022-09-22 Tobias Junghans <[email protected]>
* rfb/rfb.h: rfb: remove unused variable declaration
2022-09-24 Christian Beier <[email protected]>
* common/sockets.c: common: fix typo in sock_set_nonblocking() Closes #535
2022-08-23 Tobias Junghans <[email protected]>
* CMakeLists.txt, common/sockets.c, common/sockets.h,
libvncclient/sockets.c, rfb/rfbconfig.h.cmakein: libvncclient: use
poll() if available select() does not work with file descriptors > 1024 so use the more
modern poll() function if available.
2022-08-11 Maksym Sobolyev <[email protected]>
* libvncserver/cursor.c: libvncserver: ensure cursorMutex is locked
before cursor access This fixes multiple crashes with VirtualBox 6.1.x running Ubuntu
22.04 guest when remote cursor is enabled (TightVNC client).
2022-08-11 Christian Beier <[email protected]>
* libvncserver/httpd.c, libvncserver/sockets.c: libvncserver: clear
fd sets before closing sockets This caused fdsan aborts due to
0c9e68a9cc0abd8eda232bad169a62ff352fc571.
2022-08-11 Christian Beier <[email protected]>
* libvncserver/sockets.c: libvncserver: make rfbConnectToTCPAddr()
time out ...using rfbMaxClientWait for now. Closes #532
2022-08-11 Christian Beier <[email protected]>
* CMakeLists.txt, common/sockets.c, common/sockets.h,
libvncclient/sockets.c, libvncserver/sockets.c: common: move here
two socket helper functions from server and client re #532
2022-08-11 Christian Beier <[email protected]>
* Doxyfile: docs: don't show internals in Doxygen-docs
2022-08-09 Christian Beier <[email protected]>
* libvncclient/rfbproto.c: libvncclient: prevent acting on
ExtendedDesktopSize with 0 dimensions This is sent by UltraVNC 1.3.2 at least.
2022-08-05 Christian Beier <[email protected]>
* libvncserver/main.c: libvncserver: prevent cursor drawing during
framebuffer exchange Fixes segfaults in rfbHideCursor(), maybe elsewhere, too.
2022-08-05 Christian Beier <[email protected]>
* libvncserver/main.c: libvncserver: lock out client reads during
framebuffer exchange Closes #435
2022-08-05 Maxim Devaev <[email protected]>
* CMakeLists.txt, libvncclient/tls_gnutls.c: libvncclient: use
gnutls_handshake_set_timeout()
2022-08-05 Christian Beier <[email protected]>
* libvncserver/tight.c: libvncserver/tight: avoid division-by-zero
2022-08-04 Christian Beier <[email protected]>
* rfb/rfbproto.h: rfb/rfbproto: extend rfbCloseSocket() to prevent
double closes Specifically on Android newer 11, this would cause aborts by the
fdsan checker, see
https://developer.android.com/about/versions/11/behavior-changes-all#fdsanIt's also generally safer to mark a closed fd as closed as to not
try to re-use it.
2022-08-04 Maxim Devaev <[email protected]>
* libvncclient/tls_gnutls.c: libvncclient: rfbAnonTLSPriority =
"NORMAL:+ANON-ECDH:+ANON-DH" (#530) I.e. added ANON-ECDH just for better compatibility. Taken from
TigerVNC.
2022-08-04 Maxim Devaev <[email protected]>
* libvncclient/rfbproto.c, libvncclient/tls_gnutls.c,
libvncclient/tls_openssl.c: libvncclient: allow non-encrypted
subauth methods inside VeNCrypt (#529) Following https://github.com/LibVNC/libvncserver/issues/458 rfbNoAuth and rfbVncAuth are not actually part of VeNCrypt, however
it is important to support them to ensure better compatibility.
When establishing a connection, the client does not know whether the
server supports encryption, and always prefers VeNCrypt if enabled
Next, if encryption is not available on the server, the connection
will fail. Since the RFB doesn't have any downgrade methods in case
of failure, a client that does not support unencrypted VeNCrypt
methods will never be able to connect. rfbVeNCryptPlain is also supported for better compatibility. The RFB specification also considers any ordinary subauths are
valid, which legitimizes this solution: -
https://github.com/rfbproto/rfbproto/blob/master/rfbproto.rst#vencrypt> any of the normal VNC security types (except VeNCrypt) may be sent For security and backward compatibility reasons, encrypted
connections take precedence over unencrypted ones
2022-08-03 Christian Beier <[email protected]>
* libvncserver/main.c, libvncserver/sockets.c, rfb/rfb.h:
libvncserver: indicate client thread end by other means than sock v2 This is a less intrusive version of
336fc84ed055577473df738239dc342426a1ba08 Before, the client-to-server thread would end when the client's
socket was set to RFB_INVALID_SOCKET. However, there's a race
condition where the client's socket can be set to invalid while the
client-to-server thread is in select(), causing
https://github.com/bk138/droidVNC-NG/issues/8. Fix this by: * introducing an additional RFB_SHUTDOWN state for clients * use this as an end condition in the client-to-server thread
instead of the socket * move the self-pipe notification to rfbCloseClient from rfbShutdownServer, but only pthread_join() in rfbShutdownServer
2022-07-24 Christian Beier <[email protected]>
* libvncserver/main.c, libvncserver/sockets.c, rfb/rfb.h: Revert
"libvncserver: indicate client thread end by other means than
socket" This reverts commit 336fc84ed055577473df738239dc342426a1ba08. Waiting for the client-to-server thread to finish in
rfbCloseClient() caused deadlocks in production environments. Revert the patch and redo in a little bit less intrusive way.
2022-07-18 Christian Beier <[email protected]>
* libvncserver/main.c, libvncserver/sockets.c, rfb/rfb.h:
libvncserver: indicate client thread end by other means than socket Before, the client-to-server thread would end when the client's
socket was set to RFB_INVALID_SOCKET. However, there's a race
condition where the client's socket can be set to invalid while the
client-to-server thread is in select(), causing
https://github.com/bk138/droidVNC-NG/issues/8. Fix this by: * introducing an additional RFB_SHUTDOWN state for clients * use this as an end condition in the client-to-server thread
instead of the socket * move the self-pipe notification to rfbCloseClient from rfbShutdownServer.
2022-07-18 Christian Beier <[email protected]>
* libvncserver/rfbserver.c: libvncserver: ensure refCount==0 when
disconnecting other clients The idea is taken from rfbShutdownServer().
2022-07-14 Tobias Junghans <[email protected]>
* libvncclient/rfbproto.c: libvncclient: add missing return value to
SendExtDesktopSize
2022-07-14 Christian Beier <[email protected]>
* examples/example.c: examples/blooptest: add a way of shutting down
from the main thread
2022-07-05 Christian Beier <[email protected]>
* CMakeLists.txt, client_examples/sshtunnel.c: client_examples: add
SSH tunneling example using libssh2
2022-06-23 badda71 <[email protected]>
* libvncclient/sockets.c: libvncclient: replace gethostbyname() with
getaddrinfo() man gethostbyname: "The gethostbyname*(), gethostbyaddr*(),
herror(), and hstrerror() functions are obsolete. Applications
should use getaddrinfo(3), getnameinfo(3), and gai_strerror(3)
instead." Furthermore, the man page states that `gethostbyname()` is
MT-Unsafe, probably due to the fact that it retuns a pointer to
static data. Thus, by using `getaddrinfo()`, we improve the
multithreading soundness of LibVNCClient.
2022-06-16 Christian Beier <[email protected]>
* client_examples/ppmtest.c: client_examples/ppmtest: only handle
message if wait yielded one This is more correct and in line with the other examples.
2022-05-12 Fabrice Fontaine <[email protected]>
* common/crypto_openssl.c: common/crypto_openssl.c: fix build with
libressl >= 3.5.0 (#522) Fix the following build failure with libressl >= 3.5.0:
/nvmedata/autobuild/instance-26/output-1/build/libvncserver-0.9.13/common/crypto_openssl.c: In function 'dh_generate_keypair':
/nvmedata/autobuild/instance-26/output-1/build/libvncserver-0.9.13/common/crypto_openssl.c:149:7: error: dereferencing pointer to incomplete type 'DH' {aka 'struct dh_st'} 149 | dh->p = BN_bin2bn(prime, keylen, NULL); | ^~ Fixes: -
http:https://autobuild.buildroot.org/results/49b3940b9d0432cb5fb0c5d22dfa017b18c6e233Signed-off-by: Fabrice Fontaine <[email protected]>
2022-05-10 Christian Beier <[email protected]>
* README.md: README: document transport and encryption support
2022-05-09 Christian Beier <[email protected]>
* rfb/rfb.h: rfb/rfb.h: increase UPDATE_BUF_SIZE by 2768 bytes Simply raise the default to 32768 which is not an awful lot of an
increase and should not hurt the embedded guys. If someone needs more, we can still go down the malloc() route and
make the buffer size configurable, but leave this to the users to
request and KISS for now. Closes #521
2022-05-08 Christian Beier <[email protected]>
* examples/repeater.c: examples: extend repeater docs with a HOWTO
for an UltraVNC repeater Closes #87
2022-05-07 Christian Beier <[email protected]>
* examples/repeater.c: examples: fix repeater rfbInitServer(), which zeros out all the server's fds, was called
after the client was connected, essentially erasing info about the
just-made connection. Call it before connecting out so that the new client's info
persists. Closes #465
2022-04-28 Antenore Gatta <[email protected]>
* client_examples/vnc2mpg.c: client_examples: explicitly include
avcodec.h for ffmpeg example Build fails with the master branch of FFmpeg with these kinds of
errors: ``` ../client_examples/vnc2mpg.c:55:5: error: unknown type name
âAVCodecContextâ AVCodecContext *enc; ^~~~~~~~~~~~~~ ``` This patch adds `libavcodec/avcodec.h` in vnc2mpg.c
2022-04-27 Christian Beier <[email protected]>
* README.md: README: add a commercial use FAQ Closes #437
2022-04-27 Christian Beier <[email protected]>
* TODO.md: TODO: delete and create/update issues #515, #396, #516, #517, #518, #519
2022-04-19 Christian Beier <[email protected]>
* rfb/rfbclient.h: rfb/rfbclient: document new screen member re #511, #341
2022-04-19 Marco Fortina <[email protected]>
* client_examples/SDLvncviewer.c, libvncclient/rfbproto.c,
libvncclient/vncviewer.c, rfb/rfbclient.h: libvncclient: add support
for SetDesktopSize This adds support for
https://github.com/rfbproto/rfbproto/blob/master/rfbproto.rst#setdesktopsize in libvncclient.Closes #341, closes #452.
2022-04-16 Alex Converse <[email protected]>
* test/encodingstest.c: test/encodingstest: fix some ASAN issues - rfbClientCleanup which is automatically in some failure scenarios tries to interepret client data as rfbClientData - sizeof char pointer vs array
2022-04-14 Alex Converse <[email protected]>
* libvncserver/translate.c: libvncserver: fix pixel format equality
for different values of trueColour Compare boolean truthiness only. The spec implies that only zero vs
non-zero matters.
https://github.com/rfbproto/rfbproto/blob/master/rfbproto.rst#setpixelformat
2022-04-10 maxnet <[email protected]>
* libvncserver/sockets.c, libvncserver/websockets.c: libvncserver:
fix buffer overflow in webSocketsEncodeHybi() The websocket code has internal buffers that expect data not to be
larger than UPDATE_BUF_SIZE - Modify rfbWriteExact() to split larger writes in multiple frames. - Let webSocketsEncodeHybi() return -1 if somebody else tries to pass a too large buffer to it. (While in the libvncserver code rfbWriteExact() is the only function that calls websocketEncode(), it is exposed by rfb.h, so could theoretically also be called from application code) Closes #484 Signed-off-by: Floris Bos <[email protected]>
2022-04-10 maxnet <[email protected]>
* libvncserver/main.c, libvncserver/private.h,
libvncserver/rfbserver.c, libvncserver/tight.c,
libvncserver/zlib.c, rfb/rfb.h: libvncserver: remove thread local
storage in Tight and Zlib handling ...to prevent artifacts on ARM platform (#490) * zlib encoding: remove use of TLS variables Use the beforeEncBuf/afterEncBuf members of rfbClientRec that are
used by multiple encodings as buffers, instead of TLS variables. Fixes memory leak in which buffers were never free'd on client
disconnect. (rfbZlibCleanup() never did anything, as it was not
called from the client output thread in which the buffer's where
malloc'ed. Cannot see the value of TLS variables from other
threads. beforeEncBuf/AfterEncBuf does get freed by existing code in
rfbClientConnectionGone() ) Signed-off-by: Floris Bos <[email protected]> * tightvnc encoding: remove use of TLS variables - Moves some TLS variables to rfbClientRec. Palette to stack. - Prevents artifacts on ARM platform Closes #363 Closes #442 Closes #451 - Fixes memory leak in which buffers are not free'd after client disconnect. Signed-off-by: Floris Bos <[email protected]> * Tight: make CodeQL happy Co-authored-by: Christian Beier <[email protected]>
2022-04-06 Christian Beier <[email protected]>
* libvncserver/tightvnc-filetransfer/handlefiletransferrequest.c:
libvncserver: fix Tight file transfer root for Android
2022-04-06 Christian Beier <[email protected]>
* libvncserver/tightvnc-filetransfer/rfbtightserver.c: libvncserver:
init Tight file transfer also if no cmdline args there
2022-04-06 Christian Beier <[email protected]>
* examples/filetransfer.c: examples: register extension before
rfbGetScreen()
2022-03-30 dsilakov <[email protected]>
* libvncserver/websockets.c: libvncserver: prevent crash on
incomplete WebSocket handshake
2022-03-30 Thorsten Scherer <[email protected]>
* CMakeLists.txt: CMake: Make Source file extensions explicit Compiling using version 3.20.5 cmake yields a warning like the
following: CMake Warning (dev) at CMakeLists.txt:490 (add_library): Policy CMP0115 is not set: Source file extensions must be
explicit. Run "cmake --help-policy CMP0115" for policy details.
Use the cmake_policy command to set the policy and suppress this
warning. File: /<build-path>/libvncserver-0.9.13/common/crypto_libgcrypt.c Fix this warning by adding the file extension. While doing this make the extension for crypto_openssl explicit as
well. Signed-off-by: Thorsten Scherer <[email protected]>
2022-03-18 Alex Converse <[email protected]>
* rfb/rfb.h: libvncserver: fix ABI compatility with v0.9.13 Move added rfbScreenInfo member to the end of the struct. Fixes https://github.com/LibVNC/libvncserver/issues/507
2022-03-16 badda71 <[email protected]>
* libvncclient/rfbproto.c: libvncclient: detect UltraVNC and
TightVNC servers by security type ...in addition to using the legacy way of checking RFB protocol
versions. Closes #505
2022-03-05 Tobias Junghans <[email protected]>
* libvncclient/cursor.c, libvncserver/cursor.c,
libvncserver/hextile.c, libvncserver/selbox.c, libvncserver/tight.c:
Fix potential multiplication overflows (#504)
2022-02-15 Christian Beier <[email protected]>
* CMakeLists.txt: CMake: check for htobe64 in sys/endian.h as well Closes #499 Credits and thanks go to Derek Schrock for pointing this out.
2022-02-15 Derek Schrock <[email protected]>
* libvncserver/websockets.c, libvncserver/ws_decode.h:
libvncserver/ws_decode: include endian.h in ws_decode.h
2022-01-23 Christian Beier <[email protected]>
* libvncserver/rfbssl_gnutls.c: libvncserver/rfbssl_gnutls: fix
crash when no -sslcertfile set Actually bail out on the same condition as rfbssl_openssl does. Spotted by Joel Hutchinson <[email protected]>, thanks!
2022-01-20 Gaurav Ujjwal <[email protected]>
* libvncclient/tls_openssl.c: libvncclient/tls_openssl: Update
anonymous cipher list (#494) Using 'aNULL' enables anonymous Elliptic Curve cipher suits. It
improves compatibility with some TLS libraries, e.g. GnuTLS. Ref: https://www.openssl.org/docs/man1.1.1/man1/ciphers.html
2021-12-10 archont94 <[email protected]>
* CMakeLists.txt: CMake: allow to build without examples or tests Co-authored-by: archont94 <[email protected]>
2021-12-08 Christian Beier <[email protected]>
* CONTRIBUTING.md: CONTRIBUTING: add (some) contribution guidelines
2021-12-01 archont94 <[email protected]>
* libvncserver/main.c,
libvncserver/tightvnc-filetransfer/rfbtightserver.c, rfb/rfb.h,
rfb/rfbregion.h: libvncserver: change functions taking no args from
f() to f(void) ... as () means any number of arguments opposed to (void) which
means none.
2021-09-27 Christian Beier <[email protected]>
* README.md: README: document how to use in common buildsystems
(#481)
2021-09-26 Kang Lin <[email protected]>
* CMakeLists.txt, cmake/Modules/LibVNCServerConfig.cmake.in: CMake:
add cmake configure files (#472)
2021-09-22 Christian Beier <[email protected]>
* README.md: README: document that UltraVNC MSLogonII is now
supported re #480
2021-09-22 Christian Beier <[email protected]>
* README.md: README: let TravisCI badge point to travis-ci.com
2021-09-22 Kyle Evans <[email protected]>
* libvncclient/rfbproto.c, rfb/rfbproto.h: libvncclient: implement
UltraVNC's MSLogonII authentication scheme (#480) UltraVNC's MSLogonII protocol is relatively simple; the server sends
along DH parameters, we generate a shared secret, and we encrypt
both the username and password with it. The pubkey, username, and
password then get written back to the server. Fixes #372
2021-07-19 Christian Beier <[email protected]>
* libvncclient/zrle.c: libvncclient: fix stack buffer overflow in
ZRLE handler The for loop iterates 'type' times which could exceed the former
palette array size 16. Fix this by increasing the palette array
size. Spotted by Max Hofmann, thanks!
2021-07-19 Christian Beier <[email protected]>
* libvncclient/trle.c: libvncclient: guard against another buffer
overflow in TRLE handling Spotted by Ilja Van Sprundel, thanks!
2021-07-14 Christian Beier <[email protected]>
* libvncclient/tight.c: libvncclient: guard against heap overflow in
Tight encoding Spotted by Lukas Kupczyk, thanks!
2021-07-14 Christian Beier <[email protected]>
* libvncclient/ultra.c: libvncclient: handle negative payload sizes
for ultra encoding Spotted by Lukas Kupczyk, thanks!
2021-06-12 Christian Beier <[email protected]>
* CMakeLists.txt: CMake: improve libjpeg-turbo fallback check
2021-06-12 Christian Beier <[email protected]>
* CMakeLists.txt: CMake: fix TurboVNC-related regex
2021-06-12 Christian Beier <[email protected]>
* CMakeLists.txt: CMake: test jpeglib.h header for TurboVNC if
compile check fails
2021-05-22 Christian Beier <[email protected]>
* libvncclient/trle.c: libvnclient: guard against buffer overflow in
TRLE handling Spotted by Max Hofmann, thanks!
2021-06-04 Christian Beier <[email protected]>
* libvncserver/rfbserver.c: libvncserver: ensure reverse conn is
started in threaded mode
2021-05-28 Ryo Ota <[email protected]>
* examples/mac.c: examples/mac: fix a typo
2021-05-26 Tobias Junghans <[email protected]>
* libvncserver/rfbserver.c: libvncserver: pass unsigned char
pointers to zlib
2021-05-26 Tobias Junghans <[email protected]>
* libvncserver/rfbserver.c: libvncserver: fix string truncation
warning Calling snprintf with two arguments already containing up to
MAX_PATH bytes causes some GCC versions to complain about potential
string truncation: libvncserver/rfbserver.c: In function 'rfbSendDirContent': libvncserver/rfbserver.c:1396:50: error: '%s' directive output may
be truncated writing up to 255 bytes into a region of size between 0
and 259 [-Werror=format-truncation=] snprintf(retfilename,sizeof(retfilename),"%s/%s", path,
direntp->d_name); ^~ libvncserver/rfbserver.c:1396:5: note: 'snprintf' output between 2
and 516 bytes into a destination of size 260 snprintf(retfilename,sizeof(retfilename),"%s/%s", path,
direntp->d_name);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~This can be fixed easily by doubling the size of retfilename.
2021-05-22 Christian Beier <[email protected]>
* libvncclient/vncviewer.c: libvncclient: ensure framebuffer alloc
doesn't leave dangling pointer Could happen when the size check failed: it would potentially leave
client->frameBuffer as a free()'d but non-NULL pointer which other
parts of the lib or application code could interpret as usable. Pointed out by Ilja Van Sprundel, thanks!
2021-05-13 Dinglan Peng <[email protected]>
* libvncserver/main.c, libvncserver/rfbserver.c, rfb/rfb.h,
rfb/rfbproto.h: libvncserver: add support for UTF8 clipboard Tested against TigerVNC and a modified version of x11vnc:
https://github.com/pdlan/x11vnc
2021-05-02 Christian Beier <[email protected]>
* .travis.yml: TravisCI: use MacOS 10.14
2021-04-26 Christian Beier <[email protected]>
* rfb/rfb.h: rfb.h: document that extension supports TightVNC-1.3.x
file transfer Closes #467
2021-04-26 Christian Beier <[email protected]>
* examples/filetransfer.c: examples: document that this is about
TightVNC-1.3.x file transfer re #467
2020-12-14 Christian Beier <[email protected]>
* : Merge pull request #454 from timgates42/bugfix_typo_functions docs: fix simple typo, funtions -> functions
2020-12-02 Christian Beier <[email protected]>
* : Merge pull request #453 from any1/qemu-extended-key-event libvncclient: add qemu extended key event
2020-11-30 Andri Yngvason <[email protected]>
* rfb/rfbproto.h: rfb/rfbproto: Add qemu extended key event
2020-11-21 Christian Beier <[email protected]>
* libvncclient/vncviewer.c: libvncclient: free vncRec memory in
rfbClientCleanup() Otherwise we leak memory. Spotted by Ramin Farajpour Cami
<[email protected]>, thanks!
2020-10-13 gitdevmod <[email protected]>
* client_examples/vnc2mpg.c: vnc2mpg: fix building on Windows 10 Fix compilation on Windows 10/mingw
2020-10-06 Christian Beier <[email protected]>
* .github/workflows/codeql-analysis.yml: Create codeql-analysis.yml
2020-09-16 sanjay-cpu <[email protected]>
* .travis.yml: TravisCI: add support for ppc64le
2020-09-16 Jonas Ådahl <[email protected]>
* libvncserver/zlib.c: zlib: Clear buffer pointers on cleanup (#444) The pointers to the buffers were freed, and the size fields were set
to 0, but the buffer pointers themsef was not set to NULL, when
shutting down, meaning the next time used, NULL checks would not
tell whether the pointer is valid. This caused crashes ending with #0 0x00007ffff73729e5 in raise () from /lib64/libc.so.6 #1 0x00007ffff735b895 in abort () from /lib64/libc.so.6 #2 0x00007ffff73b6857 in __libc_message () from /lib64/libc.so.6 #3 0x00007ffff73bdd7c in malloc_printerr () from /lib64/libc.so.6 #4 0x00007ffff73c2f1a in realloc () from /lib64/libc.so.6 #5 0x00007ffff78b558e in rfbSendOneRectEncodingZlib (cl=0x4a4b80,
x=0, y=0, w=800, h=40) at
/home/jonas/Dev/gnome/libvncserver/libvncserver/zlib.c:106 #6
0x00007ffff78b5dec in rfbSendRectEncodingZlib (cl=0x4a4b80, x=0,
y=0, w=800, h=600) at
/home/jonas/Dev/gnome/libvncserver/libvncserver/zlib.c:308 #7
0x00007ffff7899453 in rfbSendFramebufferUpdate (cl=0x4a4b80,
givenUpdateRegion=0x49ef70) at
/home/jonas/Dev/gnome/libvncserver/libvncserver/rfbserver.c:3264
#8 0x00007ffff789079d in rfbUpdateClient (cl=0x4a4b80) at
/home/jonas/Dev/gnome/libvncserver/libvncserver/main.c:1275 #9
0x00007ffff78905f5 in rfbProcessEvents (screen=0x4d5790, usec=0) at
/home/jonas/Dev/gnome/libvncserver/libvncserver/main.c:1251
2020-08-09 Christian Beier <[email protected]>
* libvncserver/auth.c: libvncserver/auth: don't keep security
handlers from previous runs Whyohsoever security handlers are stored in a variable global to the
application, not in the rfbScreen struct. This meant that security
handlers registered once would stick around forever before this
commit.
2020-08-07 Christian Beier <[email protected]>
* libvncserver/tightvnc-filetransfer/filetransfermsg.c:
libvncserver/tightvnc-filetransfer: fix ZeroSizeDataMsg send for
64bit systems
2020-08-07 Christian Beier <[email protected]>
* libvncserver/tightvnc-filetransfer/handlefiletransferrequest.c:
libvncserver/tightvnc-filetransfer: frame msg send with sendMutex
locking
2020-08-07 Christian Beier <[email protected]>
* libvncserver/scale.c: libvncserver/scale: add sendMutex locking to
ResizeFrameBuffer msg send
2020-08-04 Christian Beier <[email protected]>
* libvncserver/tightvnc-filetransfer/handlefiletransferrequest.c:
tightvnc-filetransfer: fix file upload for 64-bit systems Before, the server would read more than the actually sent 4 byte
time stamp, missing the next message's header and in turn treating
message payload as header data.
2020-07-21 Christian Beier <[email protected]>
* libvncserver/main.c: libvncserver: move self-pipe check in client
thread before any FD_ISSET ...and jump to loop start on encountering something in the
self-pipe. Rationale is that on some platforms FD_ISSET(-1) triggers `FORTIFY:
FD_ISSET: file descriptor -1 < 0`. This is the case on Android, for
instance.
2020-07-21 Christian Beier <[email protected]>
* libvncserver/main.c, rfb/rfb.h: libvncserver: properly end
listener thread on shutdown ... by using the self-pipe trick.
2020-07-20 Christian Beier <[email protected]>
* libvncserver/main.c: libvncserver: don't NULL out internal of the
default cursor ...otherwise an rfbScreen created after rfbScreenCleanup() was
called gets assigned an invalid cursor struct.
2020-07-01 Christian Beier <[email protected]>
* NEWS.md: NEWS: mention the CVEs closed by 0.9.13
2020-06-25 Christian Beier <[email protected]>
* CMakeLists.txt: CMake: only add turbojpeg test if configured
WITH_JPEG Closes #430
2020-06-25 Alexander Tsoy <[email protected]>
* CMakeLists.txt, test/includetest.sh: test: fix includetest to use
CMAKE_MAKE_PROGRAM (#431) includetest currently fais if, for example, ninja is used as a CMake
generator. Fix it by using CMAKE_MAKE_PROGRAM in the test.
2020-06-17 efim bushmanov <[email protected]>
* libvncserver/rfbserver.c: libvncserver: be more clear about code
intention * fix "backgroundLoop != FALSE" means true thingy, add missed
screen->backgroundLoop check if LIBPTHREAD defined * fix "small improv Co-authored-by: Efim Bushmanov <[email protected]>
2020-06-13 Christian Beier <[email protected]>
* ChangeLog: Update ChangeLog for 0.9.13 Closes #376
2020-06-13 Christian Beier <[email protected]>
* NEWS.md: NEWS: update
2020-06-13 Christian Beier <[email protected]>
* libvncclient/vncviewer.c: libvncclient: remove unused function
2020-06-13 Christian Beier <[email protected]>
* libvncclient/vncviewer.c: libvncclient: make sure password prompt
is shown on win32
2020-06-10 Christian Beier <[email protected]>
* libvncclient/vncviewer.c: libvncclient: don't let cleanup depend
on libjpeg build support They're not connected to libjpeg. Closes #424
2020-06-10 Christian Beier <[email protected]>
* : Merge pull request #425 from veyon/misc Various minor cleanups and type cast fixes
2020-06-10 Tobias Junghans <[email protected]>
* common/turbojpeg.c: turbojpeg: eliminate dead store
2020-06-10 Tobias Junghans <[email protected]>
* common/turbojpeg.c: turbojpeg: don't store uninitialized value If handle is NULL, tjCompress2() will not modify size and an
uninitialized stack value would be written to jpegSize.
2020-06-10 Tobias Junghans <[email protected]>
* libvncserver/rfbssl_gnutls.c: libvncserver/rfbssl_gnutls:
eliminate dead store
2020-06-10 Tobias Junghans <[email protected]>
* libvncserver/tightvnc-filetransfer/handlefiletransferrequest.c:
tightvnc-filetransfer: make global vars static
2020-06-10 Tobias Junghans <[email protected]>
* libvncserver/rfbregion.c: libvncserver: remove unused assignments
2020-06-08 Tobias Junghans <[email protected]>
* examples/cursors.c, libvncclient/sasl.c, libvncserver/sockets.c:
Minor type cast fixes and cleanups The format string indicates an unsigned integer which generates a
warning with some compilers when passing a signed int. Similarly strcpy() takes a signed char pointer.
2020-06-09 Christian Beier <[email protected]>
* NEWS.md: NEWS: update
2020-06-08 Christian Beier <[email protected]>
* : Merge pull request #415 from veyon/handle-realloc-failures Handle memory realloc failures
2020-05-27 Tobias Junghans <[email protected]>
* libvncserver/corre.c, libvncserver/rre.c, libvncserver/tight.c,
libvncserver/ultra.c, libvncserver/zlib.c: libvncserver: encodings:
handle memory realloc failures When realloc() fails, previous pointer values have to be retained to
avoid leaking memory.
2020-06-03 Christian Beier <[email protected]>
* : Merge pull request #417 from veyon/logic Fix various logical errors
2020-06-03 Christian Beier <[email protected]>
* : Merge pull request #416 from veyon/security Add NULL pointer checks + other minor security improvements
2020-06-01 Christian Beier <[email protected]>
* CMakeLists.txt, rfb/rfb.h, rfb/rfbclient.h, {common =>
rfb}/threading.h: build: make common threading header public Closes #421
2020-06-01 Christian Beier <[email protected]>
* CMakeLists.txt, test/includetest.sh: test: add test that checks if
using installed headers works re #421
2020-05-28 Christian Beier <[email protected]>
* : Merge pull request #418 from veyon/misc Proper return values for examples && alignment fixes in
libvnc[client|server]
2020-05-27 Tobias Junghans <[email protected]>
* libvncserver/sockets.c: libvncserver: sockets: unlock mutex on
error
2020-05-27 Tobias Junghans <[email protected]>
* libvncserver/scale.c: libvncserver: scale: cast to 64 bit before
shifting Since pixel_value is 64 bit the data type of the shift operand
should be 64 bit too to prevent integer overflows.
2020-05-27 Tobias Junghans <[email protected]>
* libvncserver/rfbserver.c: libvncserver: rfbserver: drop checks
before free() Also eliminate one free() which will never be called with a non-NULL
value.
2020-05-27 Tobias Junghans <[email protected]>
* libvncserver/translate.c: libvncserver: fix pointer
aliasing/alignment issue Accessing byte-aligned data through uint16_t pointers can cause
crashes on some platforms or reduce the performance. Therefore
ensure a proper stack alignment.
2020-05-27 Tobias Junghans <[email protected]>
* libvncserver/tight.c: libvncserver: tight: always free PNG palette If unused (currently not the case due to disabled code), it's NULL
anyway and free() will do nothing.
2020-05-27 Tobias Junghans <[email protected]>
* libvncclient/rfbproto.c: libvncclient: fix pointer
aliasing/alignment issue Accessing byte-aligned data through uint32_t pointers can cause
crashes on some platforms or reduce the performance. Therefore
ensure a proper stack alignment.
2020-05-27 Tobias Junghans <[email protected]>
* libvncserver/cursor.c: libvncserver: cursor: enable debugging via
macro
2020-05-27 Tobias Junghans <[email protected]>
* libvncclient/trle.c, libvncclient/zrle.c: libvncclient: fix always
false/true expressions
2020-05-27 Tobias Junghans <[email protected]>
* test/tjbench.c: test/tjbench: fix minor issues
2020-05-27 Tobias Junghans <[email protected]>
* examples/cursors.c, examples/example.c, examples/fontsel.c,
examples/repeater.c, examples/simple15.c, test/encodingstest.c:
examples: fix various logical mistakes
2020-05-27 Tobias Junghans <[email protected]>
* examples/backchannel.c, examples/camera.c,
examples/colourmaptest.c, examples/cursors.c, examples/example.c,
examples/filetransfer.c, examples/fontsel.c, examples/pnmshow.c,
examples/pnmshow24.c, examples/repeater.c, examples/simple.c,
examples/simple15.c, examples/vncev.c, examples/zippy.c: examples:
use non-zero return code on error
2020-05-27 Tobias Junghans <[email protected]>
* libvncserver/rfbserver.c: libvncserver: rfbserver: init file size
field
2020-05-27 Tobias Junghans <[email protected]>
* libvncserver/rfbregion.c, libvncserver/rfbserver.c: libvncserver:
add missing NULL pointer checks
2020-05-27 Tobias Junghans <[email protected]>
* libvncserver/corre.c, libvncserver/hextile.c, libvncserver/rre.c:
libvncserver: encodings: prevent OOB accesses
2020-05-27 Tobias Junghans <[email protected]>
* libvncserver/cargs.c, libvncserver/cursor.c, libvncserver/font.c,
libvncserver/main.c, libvncserver/rfbregion.c,
libvncserver/rfbserver.c, libvncserver/selbox.c,
libvncserver/tight.c, libvncserver/websockets.c: libvncserver:
handle memory allocation failures
2020-05-27 Tobias Junghans <[email protected]>
* common/vncauth.c: common/vncauth: handle memory allocation failure
2020-05-27 Tobias Junghans <[email protected]>
* libvncclient/rfbproto.c, libvncclient/sasl.c,
libvncclient/vncviewer.c: libvncclient: handle memory allocation
failures
2020-05-27 Tobias Junghans <[email protected]>
* examples/colourmaptest.c, examples/cursors.c, examples/example.c,
examples/fontsel.c, examples/pnmshow.c, examples/repeater.c,
examples/rotatetemplate.c, examples/simple15.c, examples/vncev.c:
examples: check for memory allocation failures
2020-05-27 Tobias Junghans <[email protected]>
* libvncclient/hextile.c, libvncclient/rfbproto.c,
libvncclient/vncviewer.c: libvncclient: fix missing/redundant
initializations
2020-05-27 Tobias Junghans <[email protected]>
* libvncserver/ws_decode.c: libvncserver: ws_decode: eliminate
duplicate code
2020-05-27 Tobias Junghans <[email protected]>
* libvncserver/rfbserver.c: libvncserver: rfbserver: drop duplicate
assignment
2020-05-27 Tobias Junghans <[email protected]>
* libvncserver/corre.c, libvncserver/rre.c: libvncserver: encodings:
disable dead code
2020-05-27 Tobias Junghans <[email protected]>
* libvncclient/sasl.c: libvncclient: clean up unused labels
2020-05-27 Christian Beier <[email protected]>
* README.md: README: simplify Android build instructions The PNG switch is not needed anymore.
2020-05-22 Christian Beier <[email protected]>
* AUTHORS: AUTHORS: bring up to date
2020-05-22 Christian Beier <[email protected]>
* AUTHORS: AUTHORS: reword some paragraphs to reflect community
development
2020-05-22 Christian Beier <[email protected]>
* NEWS.md: NEWS: add 0.9.13 release description
2020-05-19 Christian Beier <[email protected]>
* libvncclient/rfbproto.c: libvncclient/rfbproto: only select TLS or
VeNCrypt sectypes if supported by build Closes #410
2020-05-17 Christian Beier <[email protected]>
* .gitignore: .gitignore: cleanup a bit
2020-05-17 Christian Beier <[email protected]>
* .gitignore: .gitignore: add doxygen output dir
2020-05-17 Christian Beier <[email protected]>
* libvncserver/rfbserver.c: libvncserver/rfbserver: fix possible
divide-by-zero Closes #409
2020-05-14 Christian Beier <[email protected]>
* README.md: README: add CMake install instructions for various
platforms Closes #407 Thanks gauravshremayee for the initial input!
2020-05-01 Gaurav Ujjwal <[email protected]>
* libvncclient/tls_openssl.c: libvncclient/tls_openssl: Use correct
type for return value. ReadFromTLS & WriteToTLS returns value of
type int. SSL_read & SSL_write also returns an int.
2020-05-01 Gaurav Ujjwal <[email protected]>
* libvncclient/tls_openssl.c: libvncclient/tls_openssl: Remove
unused macro. This macro was introduced by
https://github.com/LibVNC/libvncserver/pull/50 . We are not using
recursive mutex anymore so this can be removed.
2020-05-01 Gaurav Ujjwal <[email protected]>
* libvncclient/tls_openssl.c: libvncclient/tls_openssl: Remove
unused variables
2020-05-10 Christian Beier <[email protected]>
* NEWS.md: NEWS: update w.r.t. mac example
2020-05-03 Christian Beier <[email protected]>
* NEWS.md: NEWS: mention client TLS locking
2020-05-02 Christian Beier <[email protected]>
* README.md: README: add supported encodings matrix
2020-05-02 Christian Beier <[email protected]>
* README.md: README: condense security type tables into one
2020-05-02 Christian Beier <[email protected]>
* README.md: README: add section about actual RFB support re #135, thanks @giox069 for the initial table
2020-04-30 Christian Beier <[email protected]>
* : Merge pull request #405 from gujjwal00/openssl-refactor Use common mutex defines for OpenSSL backend
2020-04-30 Gaurav Ujjwal <[email protected]>
* libvncclient/tls_openssl.c: libvncclient/tls_openssl: Remove
duplicate include
2020-04-30 Gaurav Ujjwal <[email protected]>
* common/threading.h, libvncclient/tls_openssl.c:
libvncclient/tls_openssl: Use common mutex defines for OpenSSL
backend. It also defers locking callback cleanup so that it will be
done by the OS when process exits.
2020-04-30 Christian Beier <[email protected]>
* : Merge pull request #401 from gujjwal00/rw-mutex Add TLS R/W mutex to rfbClient
2020-04-29 Christian Beier <[email protected]>