-
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proposed changes to method comment_block() in PO.php #4
Comments
Good catches! Thanks you a lot for reporting this. You seem to use PO classes in a thorough way. Are you interested to propose / write some tests? |
No worries buddy! I'm going to have to write some unit tests for the stuff that uses this library anyway. So, after I'm done with my integration I'll take out some time to contribute some unit tests. |
Thanks! Really appreciated! 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The method
comment_block
is called statically throughout PO.php however it's not available as such. I propose changing this to a static.Apart from this, this method calls constant
PO_MAX_LINE_LEN
on a global scope but it isn't available in this scope. Therefor I propose calling it like thisself::PO_MAX_LINE_LEN
.The text was updated successfully, but these errors were encountered: