Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in FeatureMoleculesIO with add_bonds and remove_bonds #88

Open
tonimueller opened this issue Dec 4, 2018 · 0 comments
Open

Bug in FeatureMoleculesIO with add_bonds and remove_bonds #88

tonimueller opened this issue Dec 4, 2018 · 0 comments
Labels

Comments

@tonimueller
Copy link
Member

tonimueller commented Dec 4, 2018

After some nasty error messages by the FastBondset, which gives something like

getBondIdentifier doesnt exists for bond X Y Z 

where bond would exist after refolding, the bug comes visible. The issue occurs due to the FeatureMoleculesIOUnsave which uses FeatureBondsetUnsaveCheck and calls IsValid() in the sychronize function instead of IsValidStrongCheck() for the bonds. The Feature and the 'weaker' check is needed for creating networks with bonds between images of monomer in periodic boundaries. In most cases this will not lead to an error, but if two monomers are connected and the resulting bond vector is only valid after refolding and the monomer ids differ only by one, then the function WriteMCS called by AnalyzerWriteBFM try to linearize the system and uses the unrefolded vector to find the BondIdentifier.
Hence the thing to be changed is the write class?!

@tonimueller tonimueller added the bug label Dec 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant