Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thread-safe array views are broken on develop #154

Closed
lindstro opened this issue Jan 21, 2022 · 0 comments
Closed

Thread-safe array views are broken on develop #154

lindstro opened this issue Jan 21, 2022 · 0 comments
Labels

Comments

@lindstro
Copy link
Member

With the recent refactoring of the compressed-array classes into array, cache, store, and codec, there is now a single codec, owned by the data store, that is unsafely shared among threads even when thread-private views are used. Prior to the refactoring, each private_const_view and private_view owned a private zfp_stream and bitstream for accessing compressed blocks. This unsafe sharing of state for reading and writing data results in race conditions that corrupt reads and writes. As a result, the diffusion example fails when multithreading is enabled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant