Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eliminate HAVE_MPI conditional compilation #18

Open
markcmiller86 opened this issue Jan 8, 2019 · 1 comment
Open

Eliminate HAVE_MPI conditional compilation #18

markcmiller86 opened this issue Jan 8, 2019 · 1 comment

Comments

@markcmiller86
Copy link
Member

We made the MPI code conditionally compiled originally on the idea that maybe multiple forms of parallelism would be supported here. But, do we expect to be doing anything useful at large scale without MPI? If not, having MPI conditionally compiled only complicates the code without much benefit and it should be removed.

@markcmiller86
Copy link
Member Author

So, my last commit just made this problem a bit worse. I added a bunch of conditional compilaton to make the code compile in serial. That seemed useful for debugging vaarious issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant