Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Support reading mmCIF files in pyKVFinder #107

Open
jvsguerra opened this issue May 9, 2024 · 1 comment
Open

[ENH] Support reading mmCIF files in pyKVFinder #107

jvsguerra opened this issue May 9, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@jvsguerra
Copy link
Member

Problem to solve

PDB entries with extended Chemical Component Dictionary (CCD) or PDB IDs will be distributed in PDBx/mmCIF format only, as announced by the wwPDB in collaboration with the PDBx/mmCIF Working Group. PDB entries containing these extended IDs will not be supported by the legacy PDB file format. (see previous announcement)

Reference: https://www.rcsb.org/news/feature/63ff72ccc031758bf1c30ff7

Proposal

To ensure that pyKVFinder can continue to support PDB entries with extended CCD or PDB IDs, we propose adding support for reading mmCIF files in pyKVFinder. Specifically, we propose adding a new function that can read mmCIF files in the same format as the existing read_pdb and read_xyz functions.

By adding support for reading mmCIF files in pyKVFinder, we can ensure that users can continue to use pyKVFinder to analyze PDB entries with extended CCD or PDB IDs, without the need for manual conversion or preprocessing of the data.

Further details

The proposed function for reading mmCIF files will need to be developed in accordance with the PDBx/mmCIF format specifications. We will also need to update the documentation to reflect the new functionality.

@jvsguerra jvsguerra self-assigned this May 9, 2024
@jvsguerra jvsguerra added this to the v0.7.0 milestone May 9, 2024
@jvsguerra jvsguerra added the enhancement New feature or request label May 9, 2024
@jvsguerra
Copy link
Member Author

In commit c0b501f from branch v1.0.0, a reader for mmcif (read_mmcif) is implemented. However, it still requires testing, commenting, documentation, and optimization.

@jvsguerra jvsguerra removed this from the v0.7.0 milestone Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

1 participant