Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

browsing the logs with j/k and page turning wrong #14

Closed
KonstantinGasser opened this issue May 3, 2023 · 1 comment · Fixed by #18
Closed

browsing the logs with j/k and page turning wrong #14

KonstantinGasser opened this issue May 3, 2023 · 1 comment · Fixed by #18
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@KonstantinGasser
Copy link
Owner

When in browsing mode sometimes the initial index requested is not visible in the first line of the view. Furthermore, when using j/k to format the next/previous log item the page content gets corrupted after turning to the next page or turning one page back.

The trigger points to look for are:

  1. initial index where to start the formatting
  2. the moment the next page needs to be loaded and computed into the buffer (for both page turn forwards and backwards)
@KonstantinGasser KonstantinGasser added bug Something isn't working good first issue Good for newcomers labels May 3, 2023
@KonstantinGasser
Copy link
Owner Author

further issues with formatting:

  • if the last log line is reached and the next (non existing) is request it panics.
  • height issues when selecting a start index.

@KonstantinGasser KonstantinGasser mentioned this issue May 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Formatting issue 14 KonstantinGasser/scotty
1 participant
@KonstantinGasser