Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Environment kv editor flash when user input the first time [INS-4709] #8182

Merged
merged 3 commits into from
Nov 21, 2024

Conversation

cwangsmv
Copy link
Contributor

@cwangsmv cwangsmv commented Nov 19, 2024

Changes:

  • Add a useMemo hook so that empty environment data will generate same pair data
  • Allow user to delete the item if there's only one item exists

Closes INS-4698
Closes INS-4709

@cwangsmv cwangsmv requested a review from gatzjames November 19, 2024 09:33
@cwangsmv cwangsmv changed the title Fix: Environment kv editor flash when user input the first time Fix: Environment kv editor flash when user input the first time [INS-4709] Nov 19, 2024
CurryYangxx
CurryYangxx previously approved these changes Nov 20, 2024
@gatzjames gatzjames force-pushed the fix/environment-kv-editor-flash-issue branch from 5e00bd5 to b763dfa Compare November 20, 2024 16:23
@CurryYangxx CurryYangxx self-requested a review November 21, 2024 08:44
@cwangsmv cwangsmv enabled auto-merge (squash) November 21, 2024 08:57
@cwangsmv cwangsmv force-pushed the fix/environment-kv-editor-flash-issue branch from b763dfa to 17ae67c Compare November 21, 2024 08:57
@cwangsmv cwangsmv merged commit c9c722f into develop Nov 21, 2024
8 checks passed
@cwangsmv cwangsmv deleted the fix/environment-kv-editor-flash-issue branch November 21, 2024 09:10
Copy link

sentry-io bot commented Nov 26, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ Error: Expected fetch controller: :r30: app:https:///index.html View Issue
  • ‼️ Error: Expected fetch controller: :r1b: app:https:///index.html View Issue
  • ‼️ Error: Expected fetch controller: :r30: app:https:///index.html View Issue
  • ‼️ Error: Expected fetch controller: :r30: app:https:///index.html View Issue
  • ‼️ Error: Expected fetch controller: :r7: app:https:///index.html View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants