Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import postman env in Insomnia project level [INS-4253] #7821

Merged
merged 5 commits into from
Aug 12, 2024

Conversation

yaoweiprc
Copy link
Contributor

Before:
When importing a Postman environment in the Insomnia project level we create a new empty workspace and the environment doesn't get imported.
When importing a Postman global environment it's not supported.

Now:
When importing a Postman environment in the Insomnia project level we create a new global environment in current project and copy the variables.
When importing a Postman global environment in the Insomnia project level we create a new global environment in current project and copy the variables.

@yaoweiprc yaoweiprc requested a review from a team August 8, 2024 09:31
@yaoweiprc yaoweiprc changed the title import postman env in Insomnia project level [INS-4253] Import postman env in Insomnia project level [INS-4253] Aug 8, 2024
@@ -20,13 +20,20 @@ type Data = {
[key in EnvVar['key']]: EnvVar['value'];
};

const POSTMAN_ENV_TYPE: Record<string, string> = {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

may be we can try to use TS enum to define it

CurryYangxx
CurryYangxx previously approved these changes Aug 9, 2024
filfreire
filfreire previously approved these changes Aug 9, 2024
Copy link
Member

@filfreire filfreire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested locally, LGTM

@yaoweiprc yaoweiprc dismissed stale reviews from CurryYangxx and filfreire via aabf6cd August 12, 2024 07:19
@CurryYangxx CurryYangxx force-pushed the feat/import-env-in-project-level branch from aabf6cd to 169a967 Compare August 12, 2024 07:55
@yaoweiprc yaoweiprc merged commit df5729d into develop Aug 12, 2024
7 of 8 checks passed
@yaoweiprc yaoweiprc deleted the feat/import-env-in-project-level branch August 12, 2024 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants