update test to expose bug in regex generation #5974
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanitizing the path-variable name is not done correctly, as it sanitizes the entire path. So it also makes unintended changes.
filfreire
approved these changes
May 17, 2023
Tieske
commented
May 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sanitizing the path-variable name is not done correctly, as it sanitizes the entire path. So it also makes unintended changes.
changelog(Fixes): Fixed an issue when sanitizing the path-variable names in Inso CLI which was not done correctly, as it sanitized the entire path. So it also makes unintended changes. Now only matched path-variables are sanitized.