Universal Insomnia/Git Sync for all files (documents/collections) #5945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8d00544 to
393d41e
Compare
jackkav
reviewed
Jun 2, 2023
| @@ -17,6 +17,7 @@ interface GenericWorkspace<Scope extends 'design' | 'collection'> { | |||
| description: string; | |||
| certificates?: any; // deprecated | |||
| scope: Scope; | |||
| gitSync: boolean; | |||
There was a problem hiding this comment.
is it possible to use a meaningful string instead of a boolean to indicate gitSync, eg. gitUrl?
or a more meaningful name if gitSync is not just indicating the presence of a gitUrl.
There was a problem hiding this comment.
Moved the logic to the workspaceMeta.gitRepositoryId which already exists 🙏
5f965a6 to
4fd549f
Compare
jackkav
reviewed
Jul 5, 2023
| const vcs = useVCS({ | ||
| workspaceId, | ||
| }); | ||
| activeWorkspaceMeta?: WorkspaceMeta; |
jackkav
reviewed
Jul 5, 2023
Comment on lines
519
to
521
| if (!workspaceMeta) { | ||
| throw new Error('Workspace meta not found'); | ||
| } |
jackkav
reviewed
Jul 5, 2023
Comment on lines
89
to
93
| gitRepository?.uri && | ||
| gitRepository?._id && | ||
| gitStatusFetcher.state === 'idle' && | ||
| !gitStatusFetcher.data && | ||
| gitRepoDataFetcher.data |
There was a problem hiding this comment.
name this as a constant to indicate what its doing, or leave a comment
jackkav
approved these changes
Jul 5, 2023
55c5d06 to
fa9fa2c
Compare
filfreire
approved these changes
Jul 5, 2023
jackkav
pushed a commit
to jackkav/insomnia
that referenced
this pull request
Nov 24, 2023
…ng#5945) * share design documents and tests with insomnia sync * share collection and documents with insomnia/git sync * checkpoint * redirect when cloning (pulling) a new remote project * backend workspace card * redirect logic * local changes styles * loading indicator * fix sync button styles * use interval to refetch git * open the repo modal first before switching to git sync * use gitRepositoryId from metadata * fix sync option update * cleanup fetcher check * fixes * cleanup pull-push * undo logo change * clean git-vcs * use cloud icon for insomnia sync * cleanup card * more cleanup * better return type for fetchfetcher * update git tests * fix tests * fix some prerelease tests * fix cloning without an api spec * fix some more tests that expect a file to exist * fix lint error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changelog(New Features): Added Universal Insomnia and Git Sync for all files (Documents and Collections). It's now possible to share Design Documents with Insomnia Sync and Collections with Git Sync. It's also possible to chose and switch between method of sync (Insomnia/Git).
Highlights:
Notes:
Next steps:
Closes INS-2657