Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrades electron to 18.1.0 #4643

Merged
merged 4 commits into from
Apr 27, 2022
Merged

Conversation

dimitropoulos
Copy link
Contributor

@dimitropoulos dimitropoulos commented Mar 25, 2022

Figured it can't hurt to give this a swing. As you might have expected, we're blocked on

[app] Error: The module '/home/dimitri/src/github.com/Kong/insomnia/packages/insomnia-app/node_modules/@getinsomnia/node-libcurl/lib/binding/node_libcurl.node'
[app] was compiled against a different Node.js version using
[app] NODE_MODULE_VERSION 101. This version of Node.js requires
[app] NODE_MODULE_VERSION 103. Please try re-compiling or re-installing

but, at least it's a start.

changelog(Improvements): Upgraded to Electron 18.1.0 (which contains Chromium 100.0.4896.127)

@dimitropoulos dimitropoulos self-assigned this Mar 25, 2022
Copy link
Member

@filfreire filfreire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dimitropoulos should we update this to 18.0.1?

@DMarby DMarby changed the title upgrades electron to 18 (the beta, until GA in 4 days) Upgrades electron to 18.1.0 Apr 22, 2022
@DMarby DMarby marked this pull request as ready for review April 22, 2022 17:23
Copy link
Contributor

@jackkav jackkav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Groovy! 🕺

Copy link
Contributor Author

@dimitropoulos dimitropoulos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot_20220427_111724

seems to work and I didn't see anything in the 18.x changelogs that affects us

also tested the oauth flow (to make sure a separate window comes up fine) and that seemed to be good.

@DMarby DMarby enabled auto-merge (squash) April 27, 2022 15:23
@DMarby DMarby merged commit cced992 into Kong:develop Apr 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants