fix (style): set drag-sidebar z-index to 999 #4059
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
modal `globalZIndex` starts at 1000 (https://github.com/Kong/insomnia/blob/d53ef39c9b76aefcfa71630078d838bb95eaad56/packages/insomnia-app/app/ui/components/base/modal.tsx#L11) and anything with z-index >= 1000 will not be under overlay the first time a modal is open fixes Kong#4018
|
Do you have any idea why this only happens when you first launch the app? |
@dimitropoulos Yes it is because we increment the value of |
|
I updated the PR description to make it clearer |
dimitropoulos
approved these changes
Sep 29, 2021
develohpanda
approved these changes
Oct 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
modal
globalZIndexstarts at 1000 (insomnia/packages/insomnia-app/app/ui/components/base/modal.tsx
Line 11 in d53ef39
and anything with z-index >= 1000 will not be under overlay the first time a modal is open.
Each time a modal is opened, the value of
globalZIndexis incremented so this issue happens only one time (c.finsomnia/packages/insomnia-app/app/ui/components/base/modal.tsx
Line 107 in d53ef39
Closes #4018