Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deck validate --online does not use workspace to fetch version #1004

Open
lvermeire opened this issue Aug 17, 2023 · 0 comments
Open

Deck validate --online does not use workspace to fetch version #1004

lvermeire opened this issue Aug 17, 2023 · 0 comments

Comments

@lvermeire
Copy link

Online validation for a specific workspace does not set the workspace config when fetching the kong version, unlike every other command that uses fetchKongVersion.

deck/cmd/validate.go

Lines 120 to 125 in 574122f

func validateWithKong(ctx context.Context, kongClient *kong.Client, ks *state.KongState) []error {
// make sure we are able to connect to Kong
kongVersion, err := fetchKongVersion(ctx, rootConfig)
if err != nil {
return []error{fmt.Errorf("couldn't fetch Kong version: %w", err)}
}

https://github.com/Kong/deck/blob/574122f31dfcb1ec03d93cf2eef503d620b6b215/cmd/ping.go#L63C43-L68

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant