-
Notifications
You must be signed in to change notification settings - Fork 282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PM2.5 invalid cluster definition #828
Comments
@peterkappelt can you try this change and see if it breaks your device? |
I don't really think that my commit causes this inconsistency with the spec to be honest. What I did was only:
My commit didn't touch the existing spec of the measuredValue type, so the right question to ask is rather if all of the devices that use this cluster (except for the IKEA air quality thing) work with singlePrecision type |
What would maybe the cleanest way to get around this:
This way, all future devices can correctly use the measuredValue attribute with the correct type, while the legacy devices can still use the measuredValueLegacyHeimann attribute with the wrong type |
One of the possible problems is that ZCL attributes should be without manufacturer's code, while Heiman/Aqara should contain a manufacturer's code, which i don't know. Otherwise, i don't understand how z2m would distinguish the same attributes with different types. |
#789 tagging this issue as they are somewhat related, ideally we need a way to have duplicate cluster definitions but linked to specific devices. |
If one of them sends a manufactuereCode in the message that would indeed work. But I think the vindsturka at least does not send one. |
This issue is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be closed in 30 days |
This commit c413c02 actually creates an incorrect definition contrary to ZCL. (4.13.1.3 and 4.13.2.1 for attributes description).
All Concentration Measurement attributes should be of type "single precision".
I'm asking about a possible solution for this case. I don't know if attributes for devices with uints have manufacturerCodes and what are they.
Options I'm thinking about:
What is the best way to handle it?
Corresponding breaking changes in converters: Koenkk/zigbee-herdsman-converters@d8c4f20
The text was updated successfully, but these errors were encountered: