Fix bad conditions on if statements that were causing false DE detection #787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are two instances of the condition: if [ -n "$DE" ]; then I think if statements with this condition were ALWAYS running, because at the beginning of detectde () $DE gets initialized to "Not Present". if [[ -z "$DE" || "$DE" = "Not Present" ]]; then There was one instance of this, which I believe is supposed to have a "==" vs "=". The first part of the condition is also NEVER false, since $DE gets initialized to "Not Present", as mentioned before, so I just removed it. Fixes KittyKatt#782 (and possibly others)
|
I've stopped using screenfetch and won't be working on this any further. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two instances of the condition:
if [ -n "$DE" ]; then
I think if statements with this condition were ALWAYS running, because at the beginning of detectde () $DE gets initialized to "Not Present".
if [[ -z "$DE" || "$DE" = "Not Present" ]]; then
There was one instance of this, which I believe is supposed to have a "==" vs "=". The first part of the condition is also NEVER false, since $DE gets initialized to "Not Present", as mentioned before, so I just removed it.
Fixes #782 (and possibly others)