Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Security (BanHandler / gitlab secret key) #16

Closed
Khaaz opened this issue Feb 5, 2020 · 0 comments · Fixed by #25
Closed

Security (BanHandler / gitlab secret key) #16

Khaaz opened this issue Feb 5, 2020 · 0 comments · Fixed by #25
Labels
enhancement New feature or request v3 roadmap v3

Comments

@Khaaz
Copy link
Owner

Khaaz commented Feb 5, 2020

Roadmap v3 - Security

Overview

  • Gitlab token check (secret auth token) seems to be passed directly with no encoding. This should be checked out. (Github token in opposite seems to need a better crypto match..)
  • IPBanHandler could use a better implementation (cleanup / optimisation) especially for saving to json. This should also probably be delegated to an additional manager.
@Khaaz Khaaz added enhancement New feature or request v3 roadmap v3 labels Feb 5, 2020
@Khaaz Khaaz mentioned this issue Feb 18, 2020
Merged
@Khaaz Khaaz linked a pull request Mar 17, 2020 that will close this issue
refactor/fix: Security update #25
Merged
@Khaaz Khaaz closed this as completed Mar 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request v3 roadmap v3
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor/fix: Security update Khaaz/Discord-GitHook
1 participant
@Khaaz