Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Add to readme.md information about NEW_SAFE_RANGE #240

Closed
1 of 4 tasks
paat opened this issue Mar 10, 2024 · 3 comments
Closed
1 of 4 tasks

[Feature Request] Add to readme.md information about NEW_SAFE_RANGE #240

paat opened this issue Mar 10, 2024 · 3 comments
Labels
enhancement New feature or request help wanted Extra attention is needed stale

Comments

@paat
Copy link

paat commented Mar 10, 2024

Feature Request Type

  • Core functionality
  • Add-on hardware support (eg. audio, RGB, OLED screen, etc.)
  • Alteration (enhancement/optimization) of existing feature(s)
  • New behavior

Description

I used online tutorials to customize my Q3 Pro within keymap.c.
When defining new new keycode enums I started with KC_MYKEY = SAFE_RANGE
But I did not realize that Keychron added their own enums and defined NEW_SAFE_RANGE. So I spent hours debugging why bluetooth is not working with my custom build.

I would have been helpful to put information about NEW_SAFE_RANGE in readme.md.

@paat paat added enhancement New feature or request help wanted Extra attention is needed labels Mar 10, 2024
@exstntlmsnthrp
Copy link

I think this may have at least some peripheral relationship to #217 in that keychron has been a little vague in sharing details regarding Bluetooth and QMK programming. Thus limiting benefits of upstream QMK and making it more difficult for users to figure out. As they seem reluctant to add other information, I'd not hold my breath waiting for this.

Copy link

This issue has been automatically marked as stale because it has not had activity in the last 90 days. It will be closed in the next 30 days unless it is tagged properly or other activity occurs.
For maintainers: Please label with bug, in progress, on hold, discussion or to do to prevent the issue from being re-flagged.

@github-actions github-actions bot added the stale label Jun 11, 2024
Copy link

This issue has been automatically closed because it has not had activity in the last 30 days. If this issue is still valid, re-open the issue and let us know.
// [stale-action-closed]

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed stale
Projects
None yet
Development

No branches or pull requests

2 participants