From 164fe8cc87814bc5758890b1a60606e49efef1ba Mon Sep 17 00:00:00 2001 From: Liad Magen Date: Sun, 23 Sep 2018 17:06:29 +0200 Subject: [PATCH] fixing codacy issues: trailing spaces; replacing asserts with AssertError --- tests/use_case/test_arxiv_repo.py | 14 +++++++++----- webminer/use_cases/request_arxiv/arxiv_repo.py | 2 +- 2 files changed, 10 insertions(+), 6 deletions(-) diff --git a/tests/use_case/test_arxiv_repo.py b/tests/use_case/test_arxiv_repo.py index 3c573f6..aa3f686 100644 --- a/tests/use_case/test_arxiv_repo.py +++ b/tests/use_case/test_arxiv_repo.py @@ -52,14 +52,18 @@ def domain_arxivdocs(): """ return [arxiv_doc_1, arxiv_doc_2, arxiv_doc_3, arxiv_doc_4] +def assert_equal(arg1, arg2): + if arg1 != arg2: + raise AssertionError("Assert equal failed - values are not equal") def _check_results(domain_models_list, data_list): - assert len(domain_models_list) == len(data_list) - assert all([isinstance(dm, DomainModel) for dm in domain_models_list]) - assert set([dm.doc_id for dm in domain_models_list]) == \ - set([d['doc_id'] for d in data_list]) + assert_equal(len(domain_models_list), len(data_list)) + if not all([isinstance(dm, DomainModel) for dm in domain_models_list]): + raise AssertionError("not all domain model returned true") + assert_equal(set([dm.doc_id for dm in domain_models_list]), + set([d['doc_id'] for d in data_list])) def test_repository_list_without_parameters(domain_arxivdocs): repo = a_repo.ArxivRepo(domain_arxivdocs) - assert repo.list() == domain_arxivdocs + assert_equal(repo.list(), domain_arxivdocs) diff --git a/webminer/use_cases/request_arxiv/arxiv_repo.py b/webminer/use_cases/request_arxiv/arxiv_repo.py index 27974f3..616339a 100644 --- a/webminer/use_cases/request_arxiv/arxiv_repo.py +++ b/webminer/use_cases/request_arxiv/arxiv_repo.py @@ -79,7 +79,7 @@ def list(self, filters=None): if not filters: return self._entries - + self._entries = self.fetch_papers() result = []