Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve EDR metadata for parameters #359

Closed
maartenplieger opened this issue Mar 29, 2024 · 0 comments · Fixed by #373
Closed

Improve EDR metadata for parameters #359

maartenplieger opened this issue Mar 29, 2024 · 0 comments · Fixed by #373

Comments

@maartenplieger
Copy link
Member

maartenplieger commented Mar 29, 2024

Currently the EDR service returns the following for parameters (i18n was removed??):
(From https://geoservices.knmi.nl/edr/collections )

{
  "air_temperature_hagl": {
    "type": "Parameter",
    "id": "air_temperature_hagl",
    "label": "air_temperature_hagl",
    "unit": {
      "symbol": "C"
    },
    "observedProperty": {
      "id": "air_temperature_hagl",
      "label": "air_temperature_hagl"
    }
  }
}

Could it be adjusted towards:

{
  "air_temperature_hagl": {
    "type": "Parameter",
    "description":"HAP1(NL) Air temperature at 2 m",
    "id": "air_temperature_hagl",
    "label": "air_temperature_hagl",
    "unit": {
      "label": "degree Celsius",
      "symbol": {
        "value": "°C",
        "type": "http:https://www.opengis.net/def/uom/UCUM/"
      }
    },
    "observedProperty": {
      "id": "https://vocab.nerc.ac.uk/standard_name/air_temperature/",
      "label": "Air temperature"
    }
  }
}

Question: Do we really need id, label and unit.label ?
We need to check the covjson spec on the distinction between id, label and description

Description could be obtained from the WMS title in the WMS GetCapabilities
Suggested EDR config could be:

 <EdrParameter name="air_temperature_hagl" unit="°C" standard_name="air_temperature" label="Air temperature, 2 metre"/>

(Label TBD)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant