Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installation instructions are missing various libraries and instructions #83

Closed
fschutt opened this issue Aug 22, 2017 · 7 comments
Closed

Comments

@fschutt
Copy link

fschutt commented Aug 22, 2017

For some reason this library is needed, without it the cmake build does not succeed. Please add libkf5solid-dev to the README for Debian / Ubuntu.

EDIT: libkf5kio-dev is also missing from the package list.

With those two packages installed, the cmake .. step runs correctly.

Is there really no way to provide a package instead of letting people compile from scratch?

@fschutt
Copy link
Author

fschutt commented Aug 22, 2017

Icons on buttons are missing if the applications gets started with sudo. Not a big deal, but it would be nice to know what to click on:

image

This does not happen when the application is started regularly (without sudo).

@fschutt
Copy link
Author

fschutt commented Aug 22, 2017

Installation instructions are missing a chapter on hotspot-perfparser. Without building and installing perfparser, reading perf data files is impossible.

@fschutt fschutt changed the title Installation instructions are missing libkf5solid-dev Installation instructions are missing various libraries and instructions Aug 22, 2017
@fschutt
Copy link
Author

fschutt commented Aug 22, 2017

hotspot-perfparser seems to be a library. However, it is built as a library under /build-hotspot/lib/x86_64-linux-gnu/libexec. When I start hotspot and want to load a file, all I get is an error "failed to find hotspot-perfparser binary". Copying the library to /usr/lib or /usr/local/lib or /usr/local/bin does nothing. I don't know how to proceed at this point.

image

I mean it's great and all, but I can't even load a file, so I'm sad to say that in the current state there is no way for me to install hotspot correctly nevermind actually using it. Please fix the installation instructions.

EDIT: The last issue seems that hotspot wants the library to be relative to the binary:

"/usr/local/bin" "hotspot-perfparser" ../lib/x86_64-linux-gnu/libexec
cd failed

EDIT: Yes, that's it. I would refrain from making binary and library relative to each other, in order to be able to install hotspot system-wide.

@milianw
Copy link
Member

milianw commented Aug 24, 2017

a) I'll extend the README once I find the time.
b) We do work on AppImage support, cf. #76 . if you don't like that, nor compiling stuff yourself, don't do it and wait for your distro to ship a package you can install.
c) Don't run it as sudo. Yes, this probably makes the launcher view as-is unusable, but that's WIP. Reporting data files you recorded as root is possible (chmod), or better yet use something like https://github.com/milianw/shell-helpers/blob/master/perf-init to elevate your user rights so you don't need to be root to use perf
d) please report separate issues for, well, separate issues
e) the perfparser is not a library, it's an executable built with -fPIE which makes the mimetype show up as library.
f) so you ran make install and the installed binary could not find the libexec path? that's odd, it works fine for me. Or did you just copy stuff by hand?

@fschutt
Copy link
Author

fschutt commented Aug 24, 2017

I did copy files by hand, my mistake, sorry. Originally I only wanted to tell the issue about the README libraries, but I kept having trouble installing it so I wanted to put everything until I had the application installed into one issue. My mistake. Should I close this issue?

@milianw
Copy link
Member

milianw commented Aug 27, 2017

I'll close it once I've extended the README with the new dependencies

@milianw
Copy link
Member

milianw commented Aug 27, 2017

Ah, #84 fixed this already

@milianw milianw closed this as completed Aug 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants