Small fix to support ida versions older than 7.6 #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IDA versions older than 7.6 do not have the `ida_hexrays.rename_lvar()` function available, so a workaround is applied in that case.
|
Thanks a lot for submitting this fix! I don't think I would ever have found this issue! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IDA versions older than 7.6 do not have the
ida_hexrays.rename_lvar()available so a workaround is applied in that case.It might look stupid to "reindex" the lvars on every loop, but the pointers you get are updated after every rename, so ida crashes if you try to use the old pointers.
This should fix #14 and maybe also #21.