Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vkontakte: author information for posts #503

Open
hgrsd opened this issue Jul 3, 2022 · 1 comment
Open

vkontakte: author information for posts #503

hgrsd opened this issue Jul 3, 2022 · 1 comment
Labels
enhancement New feature or request module:vkontakte

Comments

@hgrsd
Copy link
Contributor

hgrsd commented Jul 3, 2022

Hi there!

I'm wondering whether you're open to adding author information (id) to posts (both originals and quoted posts). The information appears to be available in the scraped data.

E.g. (for non-quoted):

<a class="author" data-from-id="123456" href="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/someuser">
  Some User
</a>

or for a quoted post:

<a class="copy_author" data-parent-post-id="123455_1" data-post-id="222222_111" href="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/some href">
  Some Quoted User
</a>

Could I open a PR to add this information to the VKontaktePost data class?

@JustAnotherArchivist
Copy link
Owner

Yes, that would be good to add. The VKontaktePost object would have a user or author attribute of type User.
Some care is needed though. It appears that for non-quote posts, the link doesn't indicate whether the user is verified or not, but for quotes it does. I think the best option would be to make the verified field on User optional and then leave it as None for the non-quote posts. For quote posts, it should always be a bool though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request module:vkontakte
Projects
None yet
Development

No branches or pull requests

2 participants