Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Input normalization in discretize #566

Open
schillic opened this issue Oct 22, 2021 · 0 comments
Open

Input normalization in discretize #566

schillic opened this issue Oct 22, 2021 · 0 comments
Labels
bug Something isn't working

Comments

@schillic
Copy link
Member

The set U below must be n-dimensional (it is multiplied by A later).

U = next_set(inputset(ivp), 1)
Eψ0 = sih(P2A_abs * sih(A * U, alg.sih), alg.sih)

This relies on the user having eliminated the input matrix B already. I think discretize should do that for you instead.

Suggestion: The methods for discretize do not dispatch on the algorithm but only normalize the system. Then they call an internal function _discretize, which then dispatches on the algorithm.

@schillic schillic added the bug Something isn't working label Oct 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant