Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Choose the number of trajectories for simulation #537

Closed
schillic opened this issue Jul 31, 2021 · 0 comments · Fixed by #539
Closed

Choose the number of trajectories for simulation #537

schillic opened this issue Jul 31, 2021 · 0 comments · Fixed by #539
Assignees
Labels
bug Something isn't working

Comments

@schillic
Copy link
Member

The internal function _solve_ensemble lets you choose how many trajectories to use:

This value is then used further below.

X0_samples = sample(X0, trajectories; sampler=sampler, rng=rng, seed=seed, include_vertices=include_vertices)

But _solve_ensemble is called from solve and the argument is not passed on as expected:

ensemble_sol = _solve_ensemble(ivp, args...; kwargs...)

I suggest to not pass trajectories as keyword argument but rather take it from kwargs as with the other options here:

sampler = get(kwargs, :sampler, LazySets._default_sampler(X0))
rng = get(kwargs, :rng, LazySets.GLOBAL_RNG)
seed = get(kwargs, :seed, nothing)
include_vertices = get(kwargs, :include_vertices, false)

@schillic schillic added the bug Something isn't working label Jul 31, 2021
@schillic schillic self-assigned this Jul 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant