Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement GLGM06 scheme without order reduction #351

Open
mforets opened this issue Nov 5, 2020 · 3 comments
Open

Implement GLGM06 scheme without order reduction #351

mforets opened this issue Nov 5, 2020 · 3 comments

Comments

@mforets
Copy link
Member

mforets commented Nov 5, 2020

see http:https://ljk.imag.fr/membres/Antoine.Girard/Publications/hscc2006a.pdf Algorithm 1.

@schillic
Copy link
Member

schillic commented Nov 14, 2020

I just read the paper again. Here are some more comments:

  1. The algorithm is general in a set representation that is closed under linear map and Minkowski sum (e.g., polytopes). So the method should not be restricted to Zonotopes. And for homogeneous systems, you only need closure under linear map, so you can also use, e.g., ellipsoids.
  2. Even the algorithm with approximation (e.g., order reduction) is general in the set representation. For example, the paper only presents an algorithm with box approximation and not with order reduction (Algorithm 2). I suggest that there should be a parameter approximation that is a function that takes a set and returns a new set. This function can then be instantiated with reduce_order or box_approximation. This is also discussed in Remark 1, so the algorithm with approximation could for instance also be instantiated with ellipsoids and boxes.
  3. The implementation here looks actually different from the pseudocode to me. It would be interesting to implement the exact same algorithm as a comparison.
  4. In particular, the algorithm in the paper suggests to share the generators of the zonotopes in the sequence. This might be much better than creating copies for each ReachSet.

@mforets
Copy link
Member Author

mforets commented Nov 18, 2020

Thanks for the heads up! Let me CC @asarvind with whom we discussed about this method recently.

The implementation here looks actually different from the pseudocode to me. It would be interesting to implement the exact same algorithm as a comparison.

True. I look forward to adding one or two new variations of GLGM06 for comparison. A good candidate test is the helicopter model.

@mforets
Copy link
Member Author

mforets commented Nov 18, 2020

It would be interesting to try this method in connection to JuliaReach/LazySets.jl#2288 (efficient 2D zonotope vertex enumeration algorithm).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants