Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check _reduce_order function (from setops.jl) #120

Closed
dfcaporale opened this issue Apr 18, 2020 · 0 comments · Fixed by #121
Closed

Check _reduce_order function (from setops.jl) #120

dfcaporale opened this issue Apr 18, 2020 · 0 comments · Fixed by #121

Comments

@dfcaporale
Copy link
Member

dfcaporale commented Apr 18, 2020

function _reduce_order(Z::Zonotope{N, VN, MN}, r::Union{Integer, Rational}) where {N<:Real, VN, MN}

In the case I'm running, when reach_homog_ASB07! from ASB07 solver calls this function at Rₖ = _reduce_order(Rₖ, max_order) it doesn't reduce the order of the zonotope. In the end, it leads to out memory error.

I noticed that the following modifications in _reduce_order may fix the error:

  • m = p - floor(Int, d * (r - 1)) to m = p - floor(Int, d * r).
  • Gred = hcat(Gnotred, Gbox) by Gred = Gnotred

Nevertheless, the implemented function seems to be in agreement with Method 2 from the paper suggested by @mforets. Perhaps the article aims to reduce the zonotope order by 1, and so we need to repeat _reduce_order until reach a zonotope with order max_order desired.

@mforets mforets changed the title Check _reduce_order function (from steops.jl) Check _reduce_order function (from setops.jl) Apr 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant