Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: JuliaOpt/NLopt.jl Loading
base: v1.0.1
Choose a base ref
...
head repository: JuliaOpt/NLopt.jl Loading
compare: v1.0.2
Choose a head ref
  • 3 commits
  • 4 files changed
  • 3 contributors

Commits on Mar 9, 2024

  1. Avoid exception handling for verifying algorithm validity (#212)

    Currently, when a `Symbol` is passed to the `Opt` constructor or the
    `algorithm_name` function, the corresponding `Algorithm` object is
    obtained via a `Dict` lookup inside of a `try`/`catch`, where the
    `catch` permits throwing a more informative error. The use of exception
    handling here isn't necessary though; rather than using `getindex` and
    catching any resulting exception, we can instead use `get` with a
    default value that does not correspond to a valid algorithm and check
    for equality with that. (Alternatively we could guard the `getindex`
    with a `haskey` but that requires performing the lookup twice.) This
    change to using `get` is implemented here.
    
    To avoid duplicating the code that checks a `Symbol` for validity as an
    algorithm across multiple functions, I've defined a constructor method
    `Algorithm(::Symbol)` that includes this check. This also provides a
    pleasant simplification of the methods required, since `Symbol` and
    `Integer` inputs can now go through the same `Opt` and `algorithm_name`
    methods.
    ararslan committed Mar 9, 2024
    Configuration menu
    Copy the full SHA
    67acb7a View commit details
    Browse the repository at this point in the history

Commits on Mar 10, 2024

  1. Rethrow errors instead of returning FORCED_STOP (#194)

    Co-authored-by: Kirill Ignatiev <[email protected]>
    odow and ikirill committed Mar 10, 2024
    Configuration menu
    Copy the full SHA
    605be7e View commit details
    Browse the repository at this point in the history

Commits on Mar 12, 2024

  1. Prep for v1.0.2 (#213)

    odow committed Mar 12, 2024
    2 Configuration menu
    Copy the full SHA
    fb1e673 View commit details
    Browse the repository at this point in the history
Loading