First steps

[jw3126]

Here is how I think we should proceed:

• Make the github repo public. @tkf can you review the package? Especially check if I inserted your name + mail correctly in all appropriate places.
• Register the package and put a note in Setfield.jl README that this is an experimental successor.
• Wait for Julia 1.6 to come out. Then announce the package on discourse and make it the official successor of Setfield.jl

[tkf]

Thanks a lot for doing this!

I checked my name and email. I agree that it's a good idea to link from Setfield.jl that this package is an experimental successor.

• Wait for Julia 1.6 to come out.

Did you need some 1.6 features? I'm just curious why you'd want to wait for 1.6 (and added compat julia = "1.6"). I don't have a strong opinion on this but, since 1.6 is a feature-based release, the release date is less clear than usual. So I think it could be a bit frustrating to wait for 1.6 (just a speculation, though).

[jw3126]

We need ∘ to return a struct instead of a lambda. https://github.com/JuliaLang/julia/pull/35980/files#diff-a21a7fc275830bf9efb5b7c17c4fb98eR877

The most critical use is set on composed lens:
https://github.com/JuliaObjects/Accessors.jl/blob/master/src/lens.jl#L83-L91

[tkf]

Ah, thanks. That makes sense. We could do a hack like JuliaData/DataFrames.jl#2274 (comment) (or put it in Compat.jl) but it may not be worth doing this since 1.6 will be the next LTS.

Meanwhile, I think we better send a PR to document Base.ComposedFunction and then promote it to the public API (including its fields). I'll do this at some point but don't wait for me if you want to write it.

[tkf]

I guess documenting ComposedFunction is a very low priority task. Nobody wants to break DataFrames.jl.

[jw3126]

Why does documenting ComposedFunction break DataFrames?

[tkf]

Sorry, it was cryptic 😅. I meant that, since virtually nobody wants to break DataFrames.jl, ComposedFunction would not be changed even if we don't send a PR to promote it to a public API.

[jw3126]

Ah, I see. So to be maximally safe, we should just drop all requirements on Julia and do using DataFrames: ComposedFunction 😄

[jw3126]

JuliaLang/julia#37517

[jw3126]

@tkf I am going to make this repo public on monday if there are no objections from your side.

[tkf]

Sounds great! No objections.

[jw3126]

@tkf I would like to tag a first release (without discourse announcement yet). What do you think?

[jw3126]

@JuliaRegistrator register()

[JuliaRegistrator]

Registration pull request created: JuliaRegistries/General/23028

After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.

This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:

git tag -a v0.1.0 -m "<description of version>" 4e839837c29337650e0c8bc8c9e92a54445289c8
git push origin v0.1.0

[jw3126]

@JuliaRegistrator register()

[JuliaRegistrator]

Registration pull request updated: JuliaRegistries/General/23028

After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.

This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:

git tag -a v0.1.0 -m "<description of version>" 4e839837c29337650e0c8bc8c9e92a54445289c8
git push origin v0.1.0

[jw3126]

@JuliaRegistrator register()

[JuliaRegistrator]

Registration pull request updated: JuliaRegistries/General/23028

After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.

This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:

git tag -a v0.1.0 -m "<description of version>" 4e839837c29337650e0c8bc8c9e92a54445289c8
git push origin v0.1.0

[tkf]

Hi, sorry for the long absence, and thanks so much for pushing this project forward!

If you prefer announcing it on discourse, I think that's good too. But a few things on my wish list off the top of my head are:

• Update the "downstream" packages like https://github.com/JuliaFolds/DataTools.jl and https://github.com/queryverse/VegaLite.jl

• Add the forward-diff tutorial (I know I've been saying this for a long time! 😭)

• (Lower priority) Switch to the Tutorials/How-To/Explanation/Reference documentation system https://documentation.divio.com/. If you like the idea, I can try doing this for Accessors.jl around when I try the forward-diff tutorial.

[jw3126]

You are right, the docs could use some love. And it makes a lot of sense to improve them before announcing. If you want to tackle it that's great! Feel free to replace or delete any docs I wrote.
I can update DataTools.jl it's a package I wanted to take a look at anyway.